Makefile not respecting DESTDIR

[Jason]

Packaging fails when LOCALBASE (or /usr/local), is not respected.
Attached patch addresses the issue.

Contribution by Baptiste Daroussin (<email address hidden>)

[Jason (jason-helfman)]

updated patch file

[Jason (jason-helfman)]

updated patch file

[Arthur Borsboom (arthurborsboom)]

Hi Jason,

I have looked at your patch and the part that it should fix.
I believe there might be a problem, but the fix might not be the right fix.

Your patch changes a dynamic file created by autogen using Makefile.am as input

I also noticed that after running the autogen tool, that I couldn't find the parts you are referring too in the Makefile.in.
Maybe the issue is already solved.

The version I have been testing with is v4.5 - currently in development.
In what version did you notice this issue?

[Jason (jason-helfman)]

Bapt had noticed this issue with the import I had done recently of 4.4.0.

I believe you are correct. I should've changed the Makefile.am file. I misinterpreted the original patch.

[Jason (jason-helfman)]

In looking at the downloaded source code for this, there appears to be an already generated file (ie. Makefile.in) in the source distribution. I am no autotools master, but I recall the the '.in' file is generated from the Makefile.am file, as you noted. If this is the case, the Makefile.in file should not be in the distribution, right? Or is it ignored during the build process?

Thanks!
-jgh

[helfman@its-jhelfman03 /usr/home/helfman/Downloads/xpad-4.4.0/doc]$ ls -al
total 36
drwxr-xr-x 2 helfman helfman 512 Nov 22 07:36 .
drwxr-xr-x 7 helfman helfman 1024 Nov 22 07:37 ..
-rw-r--r-- 1 helfman helfman 279 Nov 22 07:35 Makefile.am
-rw-r--r-- 1 helfman helfman 15881 Nov 22 07:36 Makefile.in
-rw-r--r-- 1 helfman helfman 3939 Nov 22 07:35 xpad-user-help.txt
-rw-r--r-- 1 helfman helfman 1167 Nov 22 07:35 xpad.1

[Jason (jason-helfman)]

In looking through the source, there are others, as well. In my humble opinion, they can all be safely removed.

[helfman@its-jhelfman03 /usr/home/helfman/Downloads/xpad-4.4.0]$ find . -name Makefile.in
./Makefile.in
./src/Makefile.in
./images/Makefile.in
./doc/Makefile.in
./autopackage/Makefile.in

[Jason (jason-helfman)]

I heard make dist creates these, so I refer back to my autotools newbie comment :)

[Arthur Borsboom (arthurborsboom)]

I might not have done all my homework regarding automake, so please bare with me.

autogen.sh creates all the Makefile.in's by using Makefile.am

The Makefile.in is used by ./configure, so I believe these files are necessary when creating tar ball.
When I create the tar ball for on the website, I remove the automake tools and some other files.

However, when you want to run the automake tools yourself (for example for you own Linux distro), you can take all the source code, by:

bzr branch lp:xpad

If the content of the Makefile.in is incorrect, I think we should fix this in the Makefile.am
Which part do you believe is incorrect and what or how does it needs be fixed?

[Jason (jason-helfman)]

All of this is correct, and Makefile.am should be patched. Thanks!
https://svnweb.freebsd.org/changeset/ports/375296
- jgh

> On Dec 23, 2014, at 10:17 AM, Arthur Borsboom <email address hidden> wrote:
>
> I might not have done all my homework regarding automake, so please bare
> with me.
>
> autogen.sh creates all the Makefile.in's by using Makefile.am
>
> The Makefile.in is used by ./configure, so I believe these files are necessary when creating tar ball.
> When I create the tar ball for on the website, I remove the automake tools and some other files.
>
> However, when you want to run the automake tools yourself (for example
> for you own Linux distro), you can take all the source code, by:
>
> bzr branch lp:xpad
>
> If the content of the Makefile.in is incorrect, I think we should fix this in the Makefile.am
> Which part do you believe is incorrect and what or how does it needs be fixed?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1403619
>
> Title:
> Makefile not respecting DESTDIR
>
> Status in Xpad:
> Incomplete
>
> Bug description:
> Packaging fails when LOCALBASE (or /usr/local), is not respected.
> Attached patch addresses the issue.
>
> Contribution by Baptiste Daroussin (<email address hidden>)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xpad/+bug/1403619/+subscriptions

[Jason (jason-helfman)]

Here is a link to the actual patch file.
https://svnweb.freebsd.org/ports/head/deskutils/xpad-current/files/patch-doc_Makefile.am?view=markup&pathrev=375296

On Tue, Dec 23, 2014 at 11:20 AM, Jason Helfman <email address hidden>
wrote:

> All of this is correct, and Makefile.am should be patched. Thanks!
> https://svnweb.freebsd.org/changeset/ports/375296
> - jgh
>
>
>
>
> On Dec 23, 2014, at 10:17 AM, Arthur Borsboom <email address hidden>
> wrote:
>
>
> I might not have done all my homework regarding automake, so please bare
>
> with me.
>
>
> autogen.sh creates all the Makefile.in's by using Makefile.am
>
>
> The Makefile.in is used by ./configure, so I believe these files are
> necessary when creating tar ball.
>
> When I create the tar ball for on the website, I remove the automake tools
> and some other files.
>
>
> However, when you want to run the automake tools yourself (for example
>
> for you own Linux distro), you can take all the source code, by:
>
>
> bzr branch lp:xpad
>
>
> If the content of the Makefile.in is incorrect, I think we should fix this
> in the Makefile.am
>
> Which part do you believe is incorrect and what or how does it needs be
> fixed?
>
>
> --
>
> You received this bug notification because you are subscribed to the bug
>
> report.
>
> https://bugs.launchpad.net/bugs/1403619
>
>
> Title:
>
> Makefile not respecting DESTDIR
>
>
> Status in Xpad:
>
> Incomplete
>
>
> Bug description:
>
> Packaging fails when LOCALBASE (or /usr/local), is not respected.
>
> Attached patch addresses the issue.
>
>
> Contribution by Baptiste Daroussin (<email address hidden>)
>
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/xpad/+bug/1403619/+subscriptions
>
>

--
 "At any given moment, you may find the ticket to the circus that has
always been in your possession."

[Arthur Borsboom (arthurborsboom)]

Thanks for the patch file.
Now I see the code, I believe this issue has already been solved, in fact quite recent, 10 days ago.

https://bugs.launchpad.net/xpad/+bug/1402235

Can you please test with the latest source code if this has solved your issue?

[Jason (jason-helfman)]

This works great. A suggestion, though. I was going to note that it didn't
work because I couldn't find where the 'help' content was for the pad, but
I did find it with a right-click with my mouse. Suggestion is to create a
button on the pad to access 'help' as typically you will find there is a
'help' area on the main area of most applications these days.

Great patch, addition :) Thanks!

On Tue, Dec 23, 2014 at 11:28 PM, Arthur Borsboom <email address hidden>
wrote:

> Thanks for the patch file.
> Now I see the code, I believe this issue has already been solved, in fact
> quite recent, 10 days ago.
>
> https://bugs.launchpad.net/xpad/+bug/1402235
>
> Can you please test with the latest source code if this has solved your
> issue?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1403619
>
> Title:
> Makefile not respecting DESTDIR
>
> Status in Xpad:
> Incomplete
>
> Bug description:
> Packaging fails when LOCALBASE (or /usr/local), is not respected.
> Attached patch addresses the issue.
>
> Contribution by Baptiste Daroussin (<email address hidden>)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xpad/+bug/1403619/+subscriptions
>

--
 "At any given moment, you may find the ticket to the circus that has
always been in your possession."

[Arthur Borsboom (arthurborsboom)]

Hi Jason,

Good to hear this issue has already been solved.
However, if it wasn't for the other person, your input would have been sufficient to solve it also.
So, therefore my thanks.
I will mark this bug report as fix committed.

For the help part, I don't see an easy/good method the way you describe the help should be.
However, there is a right-click for the help. Also the F1 button triggers the help.

The thing I do like is the help in tray menu.
For this I will create a bug report (as a reminder to myself) and will implement it.

Thanks for your help and patience.