Special MMI strings fail in chinese language images

Bug #1403476 reported by John McAleely
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Unassigned
dialer-app
Fix Released
Undecided
You-Sheng Yang
dialer-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The system for supporting MMI plugins allows special numbers to be dialled:

*#nnnn#

Which should be directed to MMI plugins in the custom tarball. When using Chinese as a system language, this mechanism fails. Instead of attempting to use an MMI plugin, the phone dialler simply attempts to use the string as a phone number.

vivid-proposed/62

In another bug (listed as a dupe), the characters * and/or # were suspected to be different, and not parsed correctly by the dialler.

Tags: patch

Related branches

Changed in canonical-devices-system-image:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
You-Sheng Yang (vicamo) wrote :

I think I know what happened. The msgstr for char '#' in zh_CN is full width, which fails checkMMI() every time. Here are the full list of locales that have the same problem:

br.po-23-msgstr "Niv."
fa.po-23-msgstr "شماره"
nb.po-23-msgstr "Nr."
nn.po-23-msgstr ""
shn.po-23-msgstr ""
si.po-23-msgstr ""
sk.po-23-msgstr ""
th.po-23-msgstr ""
zh_CN.po-23-msgstr "#"

Following are locales with msgstr for '*' that do not equal to '*':
hi.po-60-msgstr ""
nn.po-60-msgstr ""
shn.po-60-msgstr ""
si.po-60-msgstr ""
sk.po-60-msgstr ""
th.po-60-msgstr ""

Changed in dialer-app:
assignee: nobody → Vicamo Yang (vicamo)
Revision history for this message
You-Sheng Yang (vicamo) wrote :

This proof-of-concept patch preserve the ability to have translated number strings by renaming `dailNumber` to `displayNumber`, and add back the `dialNumber` property as a raw string. Verified locally but may need some more polishment especially for syncing the two strings. Maybe this should really be implemented into PhoneNumberInput itself.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

From current qml implementation, we may have "*شمارهnnnشماره" displayed for key sequence "*#nnn#". This brings some problems when backspace and insertion in the middle come forward because it assumes each insertion always inserts one character only. After some more analysis on Android's implementation, key name localization is only effective on the displayed text on the button. This means we should not pass i18n.tr("*") but simply "*" for the keyPressed signal. This would also avoid previous one character per insertion problem.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Proposed https://code.launchpad.net/~vicamo/dialer-app/fix-1403476 to replace previous patch based on comment 3.

Changed in dialer-app:
status: New → In Progress
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "proposed patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dialer-app - 0.1+15.04.20150324-0ubuntu1

---------------
dialer-app (0.1+15.04.20150324-0ubuntu1) vivid; urgency=medium

  [ You-Sheng Yang ]
  * insert untranslated keychar to PhoneNumberInput (LP: #1403476)
 -- CI Train Bot <email address hidden> Tue, 24 Mar 2015 18:14:20 +0000

Changed in dialer-app (Ubuntu):
status: New → Fix Released
Changed in dialer-app:
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.