Xibo

Library - Owner COMBO

Bug #1402295 reported by Laercio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Undecided
Dan Garner
Xibo 1.7.0-rc1 "Tuttle"

Bug Description

The Owner COMBO, currently lists all users.

I question the functionality with the following developments:

Admin: We should display all system users, after all this user restriction need not

Admin Group: We should display all users in the group, for the group admin

User: We should show only what the user owns or what is shared from another user for it. If shared media of any user, that user should appear in the combo.

Tags: filter

Related branches

lp:~dangarner/xibo/server170
Xibo Maintainters: Pending requested
Diff: 6714 lines (+3283/-1421)
69 files modified
manual/generate.php (+4/-164)
manual/manualgenerator.class.php (+211/-0)
manual/source/en/install_environment.md (+7/-139)
manual/source/en/install_environment_linux.md (+93/-0)
manual/source/en/install_environment_windows_iis.md (+195/-0)
manual/source/en/install_environment_windows_xampp.md (+47/-0)
manual/source/en/release_notes.md (+1/-0)
manual/source/en/release_notes_1.7.0-rc1.md (+53/-0)
manual/source/fr/tour.md (+65/-0)
manual/template/template.php (+21/-1)
server/config/client.config.php (+24/-2)
server/install/database/60.sql (+13/-0)
server/install/database/80.sql (+1/-1)
server/install/database/81.sql (+1/-1)
server/install/database/83.sql (+5/-0)
server/install/master/data.sql (+3/-3)
server/install/master/structure.sql (+7/-7)
server/lib/app/kit.class.php (+58/-0)
server/lib/app/thememanager.class.php (+2/-2)
server/lib/data/dataset.data.class.php (+27/-10)
server/lib/data/datasetdata.data.class.php (+2/-2)
server/lib/data/displayprofile.data.class.php (+2/-2)
server/lib/data/layout.data.class.php (+8/-2)
server/lib/data/media.data.class.php (+1/-6)
server/lib/data/nonce.data.class.php (+11/-0)
server/lib/data/userdata.data.class.php (+85/-0)
server/lib/include.php (+1/-1)
server/lib/modules/module.class.php (+47/-12)
server/lib/pages/admin.class.php (+4/-7)
server/lib/pages/content.class.php (+53/-48)
server/lib/pages/dataset.class.php (+11/-1)
server/lib/pages/display.class.php (+25/-16)
server/lib/pages/layout.class.php (+8/-3)
server/lib/pages/log.class.php (+2/-0)
server/lib/pages/module.class.php (+40/-30)
server/lib/pages/stats.class.php (+27/-3)
server/lib/pages/timeline.class.php (+9/-2)
server/lib/pages/user.class.php (+22/-35)
server/lib/service/service_v3.wsdl (+0/-9)
server/lib/service/xmdssoap3.class.php (+566/-599)
server/lib/service/xmdssoap4.class.php (+39/-31)
server/modules/3rdparty/twitter-oauth/OAuth.php (+872/-0)
server/modules/3rdparty/twitter-oauth/twitteroauth.php (+243/-0)
server/modules/clock.module.php (+0/-19)
server/modules/datasetview.module.php (+0/-8)
server/modules/embedded.module.php (+0/-14)
server/modules/forecastio.module.php (+43/-37)
server/modules/image.module.php (+1/-1)
server/modules/module_template.php (+2/-8)
server/modules/module_user_general.php (+41/-0)
server/modules/text.module.php (+0/-14)
server/modules/theme/forecastio/current-day.template.json (+7/-0)
server/modules/theme/forecastio/daily.template.json (+7/-0)
server/modules/theme/forecastio/picture.template.json (+7/-0)
server/modules/theme/ticker/media-rss-with-title.template.json (+6/-0)
server/modules/theme/ticker/prominent-title-with-desc-and-name-separator.template.json (+6/-0)
server/modules/theme/ticker/title-only.template.json (+6/-0)
server/modules/theme/twitter/tweet-only.template.json (+6/-0)
server/modules/theme/twitter/tweet-with-profileimage-left.template.json (+6/-0)
server/modules/theme/twitter/tweet-with-profileimage-right.template.json (+6/-0)
server/modules/ticker.module.php (+55/-41)
server/modules/twitter.module.php (+152/-53)
server/modules/webpage.module.php (+0/-13)
server/theme/default/config.php (+0/-1)
server/theme/default/html/display_form_mediainventory.php (+0/-52)
server/theme/default/html/library_form_media_add.php (+11/-4)
server/theme/default/html/schedule_page.php (+1/-1)
server/theme/default/js/xibo-forms.js (+0/-12)
server/theme/default/libraries/jquery-file-upload/js/jquery.fileupload-ui.js (+4/-4)
Dan Garner (dangarner)
Changed in xibo:
milestone: none → 1.7.0
assignee: nobody → Dan Garner (dangarner)
tags: added: filter
Dan Garner (dangarner)
Changed in xibo:
status: New → Fix Committed
Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
Revision history for this message
Laercio (laercionit) wrote :

I conducted the tests and still does not work as aligned.

Revision history for this message
Dan Garner (dangarner) wrote :

What about it doesn't work?

Revision history for this message
Laercio (laercionit) wrote : Re: [Bug 1402295] Re: Library - Owner COMBO

Show allways all users...

*Laercio Junior*
Cel./Pessoal: (21) 99162-7440
Email Pessoal: <email address hidden>
MSN: <email address hidden>
Skype: laercionit

2015-01-09 14:05 GMT-02:00 Dan Garner <email address hidden>:

> What about it doesn't work?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1402295
>
> Title:
> Library - Owner COMBO
>
> Status in Xibo Open Source Digital Signage:
> Fix Released
>
> Bug description:
> The Owner COMBO, currently lists all users.
>
> I question the functionality with the following developments:
>
> Admin: We should display all system users, after all this user
> restriction need not
>
> Admin Group: We should display all users in the group, for the group
> admin
>
> User: We should show only what the user owns or what is shared from
> another user for it. If shared media of any user, that user should
> appear in the combo.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xibo/+bug/1402295/+subscriptions
>

Revision history for this message
Dan Garner (dangarner) wrote :

Can you go into lib/data/userdata.data.class.php and on line 94 comment out the Audit message. Then can you run the filter form again and get the SQL that is being run?

The logic in the code says that:

If I am a normal user, show only myself
If I am a group admin, show only users in my groups
If I am a super admin, show all users

Revision history for this message
Laercio (laercionit) wrote :

Using debug mode...

Notice: Undefined index: userId in C:\xampp\htdocs\@Teste@
\modules\module_user_general.php on line 1659

*Laercio Junior*
Cel./Pessoal: (21) 99162-7440
Email Pessoal: <email address hidden>
MSN: <email address hidden>
Skype: laercionit

2015-01-09 16:19 GMT-02:00 Dan Garner <email address hidden>:

> Can you go into lib/data/userdata.data.class.php and on line 94 comment
> out the Audit message. Then can you run the filter form again and get
> the SQL that is being run?
>
> The logic in the code says that:
>
> If I am a normal user, show only myself
> If I am a group admin, show only users in my groups
> If I am a super admin, show all users
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1402295
>
> Title:
> Library - Owner COMBO
>
> Status in Xibo Open Source Digital Signage:
> Fix Released
>
> Bug description:
> The Owner COMBO, currently lists all users.
>
> I question the functionality with the following developments:
>
> Admin: We should display all system users, after all this user
> restriction need not
>
> Admin Group: We should display all users in the group, for the group
> admin
>
> User: We should show only what the user owns or what is shared from
> another user for it. If shared media of any user, that user should
> appear in the combo.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xibo/+bug/1402295/+subscriptions
>

Revision history for this message
Laercio (laercionit) wrote :

use the debug command to perform the tests.

Displays on screen there are many mistakes ...

*Fatal error*: Class 'Theme' not found in
*C:\xampp\htdocs\@Teste@\config\client.config.php* on line *288*

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 97

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 99

Warning: Invalid argument supplied for foreach () in C: \ xampp \ htdocs \
@ Test @ \ lib \ data \ display.data.class.php on line 666

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 97

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 99

Warning: Invalid argument supplied for foreach () in C: \ xampp \ htdocs \
@ Test @ \ lib \ data \ display.data.class.php on line 666

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 97

Notice: Undefined index: in C: \ xampp \ htdocs \ @ Test @ \ lib \ data \
displayprofile.data.class.php on line 99

Warning: Invalid argument supplied for foreach () in C: \ xampp \ htdocs \
@ Test @ \ lib \ data \ display.data.class.php on line 666

*Laercio Junior*
Cel./Pessoal: (21) 99162-7440
Email Pessoal: <email address hidden>
MSN: <email address hidden>
Skype: laercionit

2015-01-09 16:37 GMT-02:00 Laercio Mendonça <email address hidden>:

> Using debug mode...
>
> Notice: Undefined index: userId in C:\xampp\htdocs\@Teste@
> \modules\module_user_general.php on line 1659
>
>
> *Laercio Junior*
> Cel./Pessoal: (21) 99162-7440
> Email Pessoal: <email address hidden>
> MSN: <email address hidden>
> Skype: laercionit
>
>
>
> 2015-01-09 16:19 GMT-02:00 Dan Garner <email address hidden>:
>
> Can you go into lib/data/userdata.data.class.php and on line 94 comment
>> out the Audit message. Then can you run the filter form again and get
>> the SQL that is being run?
>>
>> The logic in the code says that:
>>
>> If I am a normal user, show only myself
>> If I am a group admin, show only users in my groups
>> If I am a super admin, show all users
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1402295
>>
>> Title:
>> Library - Owner COMBO
>>
>> Status in Xibo Open Source Digital Signage:
>> Fix Released
>>
>> Bug description:
>> The Owner COMBO, currently lists all users.
>>
>> I question the functionality with the following developments:
>>
>> Admin: We should display all system users, after all this user
>> restriction need not
>>
>> Admin Group: We should display all users in the group, for the group
>> admin
>>
>> User: We should show only what the user owns or what is shared from
>> another user for it. If shared media of any user, that user should
>> appear in the combo.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/xibo/+bug/1402295/+subscriptions
>>
>
>

Revision history for this message
Dan Garner (dangarner) wrote :

Ah, damn - I see the problem.

modules/module_user_general.php line 1659 change to:

$filterBy['userId'] = $this->userid;

The other issues should be investigated when there is a problem - the messages are not related to this (need to debug one thing at a time otherwise it gets very complicated).

Revision history for this message
Dan Garner (dangarner) wrote :

https://bugs.launchpad.net/xibo/+bug/1409107

Revision history for this message
Dan Garner (dangarner) wrote :

Also created one for the other errors: https://bugs.launchpad.net/xibo/+bug/1409108

Revision history for this message
Laercio (laercionit) wrote :

Hello Dan,
Your change worked.
Another point that also realized and had registered the bug, but it still
happens in rc1

https://bugs.launchpad.net/xibo/+bug/1397762

*Laercio Junior*
Cel./Pessoal: (21) 99162-7440
Email Pessoal: <email address hidden>
MSN: <email address hidden>
Skype: laercionit

2015-01-09 17:11 GMT-02:00 Dan Garner <email address hidden>:

> Ah, damn - I see the problem.
>
> modules/module_user_general.php line 1659 change to:
>
> $filterBy['userId'] = $this->userid;
>
>
> The other issues should be investigated when there is a problem - the
> messages are not related to this (need to debug one thing at a time
> otherwise it gets very complicated).
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1402295
>
> Title:
> Library - Owner COMBO
>
> Status in Xibo Open Source Digital Signage:
> Fix Released
>
> Bug description:
> The Owner COMBO, currently lists all users.
>
> I question the functionality with the following developments:
>
> Admin: We should display all system users, after all this user
> restriction need not
>
> Admin Group: We should display all users in the group, for the group
> admin
>
> User: We should show only what the user owns or what is shared from
> another user for it. If shared media of any user, that user should
> appear in the combo.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xibo/+bug/1402295/+subscriptions
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.