FBO used for webview capture rendered everytime the webview is updated, impacts rendering performance
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app |
Fix Released
|
Medium
|
Olivier Tilloy | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Olivier Tilloy | ||
Bug Description
The current mechanism to implement tab previews in the browser uses a ShaderEffectSource on the WebView, which basically renders the WebView into a FBO. To ensure that the preview is always up-to-date, the 'live' property is set to true as long as the webview is visible, meaning that every pixel visible on screen is rendered twice.
This has a performance impact, which could be minimized if we found a way to have the 'live' property always false, except when a capture is requested.
Alternatively, the capture mechanism could be implemented in oxide, thus achieving a better performance, and removing complexity from the browser itself.
Note that https:/
Related branches
- Ken VanDine: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Loïc Molinari: Pending requested
- Florian Boucault: Pending requested
-
Diff: 705 lines (+71/-388)13 files modifieddebian/control (+3/-5)
src/Ubuntu/Web/plugin.cpp (+15/-1)
src/app/webbrowser/BrowserTab.qml (+22/-37)
src/app/webbrowser/CMakeLists.txt (+1/-4)
src/app/webbrowser/file-operations.cpp (+14/-1)
src/app/webbrowser/file-operations.h (+3/-1)
src/app/webbrowser/item-capture.cpp (+0/-123)
src/app/webbrowser/item-capture.h (+0/-62)
src/app/webbrowser/webbrowser-app.cpp (+0/-2)
tests/unittests/qml/CMakeLists.txt (+2/-3)
tests/unittests/qml/tst_BrowserTab.qml (+1/-21)
tests/unittests/qml/tst_ItemCapture.qml (+0/-125)
tests/unittests/qml/tst_QmlTests.cpp (+10/-3)
| Changed in webbrowser-app: | |
| status: | Triaged → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ CI Train Bot ]
* New rebuild forced.
[ Olivier Tilloy ]
* Use the new Item::grabToImage() API (new in Qt 5.4) to replace the
custom ItemCapture element. (LP: #1401581, #1425550)
[ Robert Bruce Park ]
* Launchpad automatic translations update.
-- CI Train Bot <email address hidden> Thu, 26 Feb 2015 18:10:41 +0000