Nova launch instance from snapshot ignores --min-disk

[Tzach Shefi]

Description of problem: Nova launch instance from Horizon, if glance image has --min-disk set insufficient flavors are filtered out. When launching from a snapshot with --min-disk set, flavors aren't filtered out, they all show up even flavors with insufficient disk size.

Version-Release number of selected component (if applicable):
rhel7
python-nova-2014.1.3-9.el7ost.noarch
openstack-nova-compute-2014.1.3-9.el7ost.noarch
openstack-nova-common-2014.1.3-9.el7ost.noarch
python-novaclient-2.17.0-2.el7ost.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Upload an image to glance, set --min-disk to say 20G
2. Try to launch an instance from within horizon from that image, notice tiny flavor is grayed out.
3. From the booted instance above create a snapshot
4. Edit that snapshot #glance image-update snapID --min-disk 20
5. From horizon boot an instance from the snapshot, notice you can select any flavor including tiny which should have been grayed out as in the case of image on step 2.

Actual results:
Tiny flavor isn't filtered from Horizon launch instance page.

Expected results:
As in the case of image if --min-disk is set any flavor with insufficient disk space should be grayed out.

If this happens to --min-disk it might also happen with --min-ram.

[Sean Dague (sdague)]

This is actually a horizon UX issue

[Matthias Runge (mrunge)]

snapshots are currently not checked for size limits in launch instance wizard

[Matthias Runge (mrunge)]

Mike, are you going to submit a fix here?

[Matthias Runge (mrunge)]

I think, this should be fixed during launch instance refactoring

[Michael Hagedorn (mike-hagedorn)]

Yeah I got sidetracked but am getting back to it in the next day or so.

On 1/15/15, 8:43 AM, "Matthias Runge" <email address hidden> wrote:

>I think, this should be fixed during launch instance refactoring
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1401101
>
>Title:
> Nova launch instance from snapshot ignores --min-disk
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>Status in OpenStack Compute (Nova):
> Invalid
>
>Bug description:
> Description of problem: Nova launch instance from Horizon, if glance
> image has --min-disk set insufficient flavors are filtered out. When
> launching from a snapshot with --min-disk set, flavors aren't filtered
> out, they all show up even flavors with insufficient disk size.
>
>
> Version-Release number of selected component (if applicable):
> rhel7
> python-nova-2014.1.3-9.el7ost.noarch
> openstack-nova-compute-2014.1.3-9.el7ost.noarch
> openstack-nova-common-2014.1.3-9.el7ost.noarch
> python-novaclient-2.17.0-2.el7ost.noarch
>
>
> How reproducible:
> Every time
>
> Steps to Reproduce:
> 1. Upload an image to glance, set --min-disk to say 20G
> 2. Try to launch an instance from within horizon from that image,
>notice tiny flavor is grayed out.
> 3. From the booted instance above create a snapshot
> 4. Edit that snapshot #glance image-update snapID --min-disk 20
> 5. From horizon boot an instance from the snapshot, notice you can
>select any flavor including tiny which should have been grayed out as in
>the case of image on step 2.
>
>
> Actual results:
> Tiny flavor isn't filtered from Horizon launch instance page.
>
> Expected results:
> As in the case of image if --min-disk is set any flavor with
>insufficient disk space should be grayed out.
>
>
> If this happens to --min-disk it might also happen with --min-ram.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1401101/+subscriptions

[Michael Hagedorn (mike-hagedorn)]

Yeah that¹s a good point, is this worth pursuing? Or fix it then
coordinate with the launch instance folks. Thoughts?

On 1/15/15, 8:43 AM, "Matthias Runge" <email address hidden> wrote:

>I think, this should be fixed during launch instance refactoring
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1401101
>
>Title:
> Nova launch instance from snapshot ignores --min-disk
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>Status in OpenStack Compute (Nova):
> Invalid
>
>Bug description:
> Description of problem: Nova launch instance from Horizon, if glance
> image has --min-disk set insufficient flavors are filtered out. When
> launching from a snapshot with --min-disk set, flavors aren't filtered
> out, they all show up even flavors with insufficient disk size.
>
>
> Version-Release number of selected component (if applicable):
> rhel7
> python-nova-2014.1.3-9.el7ost.noarch
> openstack-nova-compute-2014.1.3-9.el7ost.noarch
> openstack-nova-common-2014.1.3-9.el7ost.noarch
> python-novaclient-2.17.0-2.el7ost.noarch
>
>
> How reproducible:
> Every time
>
> Steps to Reproduce:
> 1. Upload an image to glance, set --min-disk to say 20G
> 2. Try to launch an instance from within horizon from that image,
>notice tiny flavor is grayed out.
> 3. From the booted instance above create a snapshot
> 4. Edit that snapshot #glance image-update snapID --min-disk 20
> 5. From horizon boot an instance from the snapshot, notice you can
>select any flavor including tiny which should have been grayed out as in
>the case of image on step 2.
>
>
> Actual results:
> Tiny flavor isn't filtered from Horizon launch instance page.
>
> Expected results:
> As in the case of image if --min-disk is set any flavor with
>insufficient disk space should be grayed out.
>
>
> If this happens to --min-disk it might also happen with --min-ram.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1401101/+subscriptions

[Matthias Runge (mrunge)]

Depending on when new launch instance is will be ready. Could you ask them? At least a refactoring would be required here.

[Michael Hagedorn (mike-hagedorn)]

Yeah I will coordinate with them

On 1/15/15, 10:01 AM, "Matthias Runge" <email address hidden> wrote:

>Depending on when new launch instance is will be ready. Could you ask
>them? At least a refactoring would be required here.
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1401101
>
>Title:
> Nova launch instance from snapshot ignores --min-disk
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>Status in OpenStack Compute (Nova):
> Invalid
>
>Bug description:
> Description of problem: Nova launch instance from Horizon, if glance
> image has --min-disk set insufficient flavors are filtered out. When
> launching from a snapshot with --min-disk set, flavors aren't filtered
> out, they all show up even flavors with insufficient disk size.
>
>
> Version-Release number of selected component (if applicable):
> rhel7
> python-nova-2014.1.3-9.el7ost.noarch
> openstack-nova-compute-2014.1.3-9.el7ost.noarch
> openstack-nova-common-2014.1.3-9.el7ost.noarch
> python-novaclient-2.17.0-2.el7ost.noarch
>
>
> How reproducible:
> Every time
>
> Steps to Reproduce:
> 1. Upload an image to glance, set --min-disk to say 20G
> 2. Try to launch an instance from within horizon from that image,
>notice tiny flavor is grayed out.
> 3. From the booted instance above create a snapshot
> 4. Edit that snapshot #glance image-update snapID --min-disk 20
> 5. From horizon boot an instance from the snapshot, notice you can
>select any flavor including tiny which should have been grayed out as in
>the case of image on step 2.
>
>
> Actual results:
> Tiny flavor isn't filtered from Horizon launch instance page.
>
> Expected results:
> As in the case of image if --min-disk is set any flavor with
>insufficient disk space should be grayed out.
>
>
> If this happens to --min-disk it might also happen with --min-ram.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1401101/+subscriptions

[Matthias Runge (mrunge)]

Removing assignee due to inactivity on this here

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/257424

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/257489

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257424
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fc23b53339d199fe7874ab11486ad249474ef8ec
Submitter: Jenkins
Branch: master

commit fc23b53339d199fe7874ab11486ad249474ef8ec
Author: Itxaka <email address hidden>
Date: Mon Dec 14 15:59:03 2015 +0100

    ng launch instance: Validate minimun ram for snapshot source

    On launch instance NG there was no check for
    min ram values when launching from snapshot

    Change-Id: Ifc4b5f971cbb6092823d2d72d37887193a6200fb
    Partial-Bug: #1401101

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257489
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ce8677e675ce1e7462dc941caacbd8d961104a0e
Submitter: Jenkins
Branch: master

commit ce8677e675ce1e7462dc941caacbd8d961104a0e
Author: Itxaka <email address hidden>
Date: Mon Dec 14 17:56:25 2015 +0100

    Validate minimum RAM for snapshot source

    On launch instance there was no check for
    min RAM values when launching from snapshot.
    Now when launching from snapshot it will check
    the same requirements as the images.

    Change-Id: I138476b839319f357022f9545c5104a17a382df3
    Partial-Bug: #1401101

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/335026

[Rob Cresswell (robcresswell-deactivatedaccount)]

Marking released, as it seems to be fixed in Master.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/335026
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d4ac1d28c3808575a9bbef4b67389da0593956d1
Submitter: Jenkins
Branch: stable/mitaka

commit d4ac1d28c3808575a9bbef4b67389da0593956d1
Author: Itxaka <email address hidden>
Date: Mon Dec 14 17:56:25 2015 +0100

    Validate minimum RAM for snapshot source

    On launch instance there was no check for
    min RAM values when launching from snapshot.
    Now when launching from snapshot it will check
    the same requirements as the images.

    Change-Id: I138476b839319f357022f9545c5104a17a382df3
    Partial-Bug: #1401101
    (cherry picked from commit ce8677e675ce1e7462dc941caacbd8d961104a0e)