SQL_MODE setting to traditional

Bug #1396278 reported by Joshua Harlow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
taskflow
Fix Released
High
Joshua Harlow

Bug Description

It appears the default settings of mysql_traditional_mode where we default to 'true' which sets the mysql_mode isn't needed in sqlalchemy >=0.6 (where the library itself should be detecting this). Currently when settings this the following may start to happen:

2014-11-25 00:20:59.981 12367 TRACE taskflow.persistence.backends.impl_sqlalchemy ProgrammingError: (ProgrammingError) (1064, 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \'"alembic_version"\' at line 1') 'DESCRIBE "alembic_version"' ()

See:

http://docs.sqlalchemy.org/en/rel_0_9/dialects/mysql.html#ansi-quoting-style

Joshua Harlow (harlowja)
Changed in taskflow:
importance: Undecided → High
Revision history for this message
Joshua Harlow (harlowja) wrote :
Changed in taskflow:
assignee: nobody → Joshua Harlow (harlowja)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/136938
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=cf85dd0f61dcf402c42b3649b9ed449142a1ac56
Submitter: Jenkins
Branch: master

commit cf85dd0f61dcf402c42b3649b9ed449142a1ac56
Author: Joshua Harlow <email address hidden>
Date: Mon Nov 24 17:07:52 2014 -0800

    Remove default setting of 'mysql_traditional_mode'

    The sqlalchemy versions we are using/supporting (0.6+)
    have the detection of the mysql mode built-in so only
    activate the connect setting if we are somehow overriden
    by a user who knows what they are doing.

    Fixes bug 1396278

    Change-Id: If2226d3e9f921a1c5f62a6727016fe86cd50a9b5

Changed in taskflow:
status: In Progress → Fix Committed
Joshua Harlow (harlowja)
Changed in taskflow:
milestone: none → 0.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.