pieform minvalue/maxvalue rule error
Bug #1394732 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
1.10 |
Fix Released
|
High
|
Unassigned | ||
1.8 |
Fix Released
|
High
|
Unassigned | ||
1.9 |
Fix Released
|
High
|
Unassigned |
Bug Description
Currently it does a check $value != ''
It needs to check the type as '' will be the same as 0 in this case - which is not correct because 0 will not be seen as less than 1
so it needs to be $value !== ''
I'll mark this as high as the rule is a fundamental part of the pieforms system
Changed in mahara: | |
milestone: | none → 15.04.0 |
summary: |
- pieform minvalue rule error + pieform minvalue/maxvalue rule error |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/4009