Metadata Widget doesn't support context specific title and help text

Bug #1394472 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Szymon Wróblewski

Bug Description

Basically these are items we want to be able to customize:

1. The top description text

2. The bottom description text

3. Filter box name for the left table

4. Filter box name for the right table

5. Message when there’s no item in the left table (currently showing “No available metadata”)

6. Message when there’s no item in the right table

From Julie Gravel (HP)
As I mentioned in the last email, when I changed “Available Metadata” to “Available Extra Specs” the filter box was misaligned. Looks like we also need the width of the tables to be a little wider (probably a good reason to do that for translations as well).
As for the usage of Metadata vs. Extra Specs, I believe Cinder uses both of them and they are different. If I try to use Metadata instead of Extra Specs in this case I’m sure there’ll be an uproar! For other modules, I can see that they use Metadata and Extra Specs interchangeably.

Changed in horizon:
assignee: nobody → Nikunj Aggarwal (nikunj2512)
Changed in horizon:
assignee: Nikunj Aggarwal (nikunj2512) → Szymon Wróblewski (bluex)
Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136437

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Szymon Wróblewski (bluex) wrote :

To override any string create object with custom values in parent controller and pass it to hz-metadata-widget directive using "text" attribute.

Revision history for this message
Travis Tripp (travis-tripp) wrote : Re: [Bug 1394472] Re: Metadata Widget doesn't support context specific title and help text

Thanks! I put a comment out on the patch itself.

On 11/21/14, 10:53 AM, "Szymon Wróblewski" <email address hidden>
wrote:

>To override any string create object with custom values in parent
>controller and pass it to hz-metadata-widget directive using "text"
>attribute.
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1394472
>
>Title:
> Metadata Widget doesn't support context specific title and help text
>
>Status in OpenStack Dashboard (Horizon):
> In Progress
>
>Bug description:
> Basically these are items we want to be able to customize:
>
> 1. The top description text
>
> 2. The bottom description text
>
> 3. Filter box name for the left table
>
> 4. Filter box name for the right table
>
> 5. Message when there¹s no item in the left table (currently
> showing ³No available metadata²)
>
> 6. Message when there¹s no item in the right table
>
>
> From Julie Gravel (HP)
> As I mentioned in the last email, when I changed ³Available Metadata²
>to ³Available Extra Specs² the filter box was misaligned. Looks like we
>also need the width of the tables to be a little wider (probably a good
>reason to do that for translations as well).
> As for the usage of Metadata vs. Extra Specs, I believe Cinder uses
>both of them and they are different. If I try to use Metadata instead of
>Extra Specs in this case I¹m sure there¹ll be an uproar! For other
>modules, I can see that they use Metadata and Extra Specs interchangeably.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1394472/+subscriptions

Changed in horizon:
assignee: Szymon Wróblewski (bluex) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Szymon Wróblewski (bluex)
Changed in horizon:
assignee: Szymon Wróblewski (bluex) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Szymon Wróblewski (bluex)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/157466
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1ce2c36d4d655722baaf3842ed3a335369bbeca4
Submitter: Jenkins
Branch: master

commit 1ce2c36d4d655722baaf3842ed3a335369bbeca4
Author: Szymon Wroblewski <email address hidden>
Date: Thu Feb 19 18:28:20 2015 +0100

    Refactor of Metadata Widget

    First step of making metadata widget logic reusable.

    See dependent patches. It was hard to see the changes
    in Gerrit when doing the renaming and refactoring at
    once. Gerrit didn't seem to understand that it was
    a rename, making the review more difficult to view.

    Partial-Bug: 1394472
    Change-Id: I01eac21bf78b4b5545405e1ae4cb9a11619e8bc6

Changed in horizon:
assignee: Szymon Wróblewski (bluex) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Szymon Wróblewski (bluex)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/136437
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a81a3268ae1548ccaa899d9a03d135c803b99a94
Submitter: Jenkins
Branch: master

commit a81a3268ae1548ccaa899d9a03d135c803b99a94
Author: Szymon Wroblewski <email address hidden>
Date: Thu Mar 12 14:29:33 2015 +0100

    Refactor, customization and fixes of Metadata Widget

    Allow customization of strings in Metadata Widget by extracting them
    from template to separate service.

    Fix alignment of filter boxes when longer text is provided as column
    title. Fix available filter only showing expanded items. Fix level-0
    item showing in available list when all level-2 leafs was added
    manually.

    Make the tree logic reusable by extracting it into service.

    Closes-Bug: 1394472
    Change-Id: I88f4d008f4c814747028585842769aff26ff9936

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Szymon Wróblewski (<email address hidden>) on branch: master
Review: https://review.openstack.org/164131
Reason: no longer valid

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.