Horizontal cards with summary don't get backgrounds

Bug #1393008 reported by Laszlo Kudela
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Ubuntu Developer Portal
Invalid
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
High
Andrea Cimitan
unity8 (Ubuntu RTM)
Fix Released
High
Michał Sawicz

Bug Description

If I change the WEATHER_TEMPLATE in the scopes example to:

const static string WEATHER_TEMPLATE =
        R"(
{
        "schema-version": 1,
        "template": {
        "category-layout": "carousel",
        "card-layout": "horizontal",
        "card-size": "small",
 "card-background":"color:///#0F0F0F"
        },
        "components": {
        "title": "title",
        "art" : {
        "field": "art"
        },
        "subtitle": "subtitle",
        "summary": "summary"
        }
        }
        )";

The cards are placed in carousel style, but the background color is simply omitted, the color of the card stays black.

If the card-layout is changed from "horizontal" to "vertical", the color is there, and the cards in a carousel style, but the bottom 10% of the cards seem to be clipped. (Screenshot attached)

This is my first bug report ever, so please let me know what else I should add, or if I am at the right place at all.

Reported from: http://developer.ubuntu.com/scopes/cookbook/

Related branches

Revision history for this message
Laszlo Kudela (laszlokudela) wrote :
Revision history for this message
David Callé (davidc3) wrote :

Thanks a lot for the report, I'm marking unity8 as affected since it looks like a Dash bug.

Changed in developer-ubuntu-com:
status: New → Invalid
Revision history for this message
Michał Sawicz (saviq) wrote : Re: Horizontal cards don't get backgrounds

Confirmed, something made horizontal card layouts lose background.

Changed in unity8 (Ubuntu):
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Andrea Cimitan (cimi)
summary: - Changing attributes in scope template (CategoryRenderer) has no effect
- on the layout
+ Horizontal cards don't get backgrounds
Changed in unity8 (Ubuntu):
assignee: Andrea Cimitan (cimi) → Albert Astals Cid (aacid)
Revision history for this message
Albert Astals Cid (aacid) wrote :

According to
https://docs.google.com/a/canonical.com/document/d/1n880Fih5KyGPcoP5chidnHDG_8TxXUgSuij7f4rHpuk/edit
horizontal cards without a summary don't get a shape, and since they don't get a shape, don't get background either.

This is my understanding of the table intersection of "Art_Header_horizontal" + "Can card be inside shape?" in "Cards and Ubuntu Shape" that says "No" and "The ubuntu shape is also optional for card templates which support it. In this case, the card must have a background colour"

Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Triaged → Incomplete
assignee: Albert Astals Cid (aacid) → nobody
importance: Critical → Undecided
Revision history for this message
Michał Sawicz (saviq) wrote :

OK back to us, this should work when there *is* summary, but doesn't.

Changed in unity8 (Ubuntu):
status: Incomplete → Triaged
importance: Undecided → High
assignee: nobody → Albert Astals Cid (aacid)
summary: - Horizontal cards don't get backgrounds
+ Horizontal cards with summary don't get backgrounds
description: updated
Andrea Cimitan (cimi)
Changed in unity8 (Ubuntu):
assignee: Albert Astals Cid (aacid) → Andrea Cimitan (cimi)
Andrea Cimitan (cimi)
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.02+15.04.20150113.1-0ubuntu1

---------------
unity8 (8.02+15.04.20150113.1-0ubuntu1) vivid; urgency=low

  [ Andrea Cimitan ]
  * support background on horizontal cards with summary (LP: #1393008)

  [ Gerry Boland ]
  * DashCommunicator: replace QDBusInterface with a non-blocking
    simplification which does not introspect the service on creation
    (LP: #1403508)

  [ Leo Arias ]
  * Added an autopilot test for the edges demo.

  [ Albert Astals ]
  * Don't show the manage dash pull up arrow on temp scopes (LP:
    #1401869)
  * Remove hack, newer Qt already support keyClick(char)
  * Tests: Add Qt 5.5 removal TODOs
  * Make sure we use fPIC when compiling files for the static library
    too
  * Make sure changing a scope doesn't trigger creation/destruction of
    delegates until it's finished (LP: #1410122)

  [ Michael Zanetti ]
  * patch debian/control file before using it to make it work with mk-
    build-deps
 -- Ubuntu daily release <email address hidden> Tue, 13 Jan 2015 20:58:08 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
no longer affects: ubuntu-ux
Revision history for this message
Michał Sawicz (saviq) wrote :

This is intertwined with bug #1411748.

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww09-2015
status: New → In Progress
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu RTM):
milestone: none → 14.09-ota-1
status: New → Triaged
importance: Undecided → High
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu RTM):
status: Triaged → In Progress
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.02+15.04.20150217~rtm-0ubuntu1

---------------
unity8 (8.02+15.04.20150217~rtm-0ubuntu1) 14.09; urgency=medium

  [ Albert astals ]
  * Preserve the aspect ratio for the card attribute images

  [ Andrea Cimitan ]
  * support background on horizontal cards with summary (LP: #1393008)
  * Background needs to be specified to be visible in horizontal cards
  (LP: #1411748)

  [ Daniel d'Andrada ]
  * Don't show() the lockscreen if it's already being shown

  [ Joshua Arenson ]
  * Create a PhysicalKeyMapper to handle all physical/hardware keys

  [ Michał Sawicz ]
  * Create a PhysicalKeyMapper to handle all physical/hardware keys

  [ Mirco Müller ]
  * Allow swipe-to-dismiss for contracted snap-decision notifications,
    interactive notifications and ephemeral notifications. (LP:
    #1355422, #1334855)
 -- CI Train Bot <email address hidden> Tue, 17 Feb 2015 10:47:19 +0000

Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
milestone: ww09-2015 → ww13-ota
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.