Linear flow poorly handles empty flows in it.

Bug #1392650 reported by Yuriy Taraday
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
taskflow
Fix Released
High
Joshua Harlow

Bug Description

When some empty flow is inserted into linear flow, dependencies of tasks that follow this empty flow are ignored.

Having this minimal script: http://paste.openstack.org/show/133084/ I got this exception with master taskflow: http://paste.openstack.org/show/133078/ and this with latest released version: http://paste.openstack.org/show/133085/

I both cases there's no edges in execution graph at all: http://paste.openstack.org/show/133087/

Joshua Harlow (harlowja)
Changed in taskflow:
importance: Undecided → High
milestone: none → next-kilo
Joshua Harlow (harlowja)
Changed in taskflow:
status: New → Confirmed
assignee: nobody → Joshua Harlow (harlowja)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135146

Changed in taskflow:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/135146
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=eaf49950383865438dd5aaef05de7d86977403f5
Submitter: Jenkins
Branch: master

commit eaf49950383865438dd5aaef05de7d86977403f5
Author: Joshua Harlow <email address hidden>
Date: Mon Nov 17 16:28:49 2014 -0800

    Properly handle and skip empty intermediary flows

    Instead of linking nodes which have elements to
    predecessors which do not we should search backwards
    through the prior predecessors and link to one that
    does have nodes; this ensures that we do not create
    bad workflows when empty flows are injected.

    Fixes bug 1392650

    Change-Id: Ic362ef3400f9c77e60ed07b0097e3427b999d1cd

Changed in taskflow:
status: In Progress → Fix Committed
Joshua Harlow (harlowja)
Changed in taskflow:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.