[ubuntu- 14.10] librtas: fixes for LE support

Bug #1391322 reported by bugproxy
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
librtas (Ubuntu)
Fix Released
Undecided
Adam Conrad
Trusty
Fix Released
Undecided
Adam Conrad
Utopic
Fix Released
Undecided
Adam Conrad

Bug Description

[Justification]
librtas is an interface to a hardware management system specific to IBM POWER servers. It is built for Ubuntu's powerpc and ppc64el architectures. However, the version in Ubuntu 14.04 lacks full support for running on a little-endian host (ppc64el); and because powerpc is a 32-bit host OS its usage on IBM POWER servers is minimal. This is a hardware-enablement SRU to fix behavior of librtas on ppc64el.

[Test case]
Proper functioning of librtas to be confirmed by IBM.

[Regression potential]
The new upstream version of librtas includes endianness fixes and new APIs. The current package is of minimal utility on powerpc and is known to not work on ppc64el. Risk of regression is negligible.

---Problem Description---
Please include these additional patches to fix support for LE.

Machine Type = POWER8

Userspace tool common name: rtas_errd

Userspace package: librtas

Please pull below patchset from upstream.

upstream repo : git://git.code.sf.net/p/librtas/code

commit 1d54a4a346f9111e1326dfdec756fd78360add42
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:18:40 2014 -0400

    When we pass _hi and _lo 32bits of a 64bit value, we
    should convert the host endian value carefully.

    i.e,
            X_hi = htobe32(BITS32_HI(X))
            X_lo = htobe32(BITS32_LO(X))

    and not :
            X_hi = BITS32_HI(htobe64(X))

    NOTE: This patch is untested, but I believe this patch
    is good to have than the current faulty conversion.

    This patch fixes all such occurrences in librtas.

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit e5541e1a5c83ce47cc492abcd7343d65763dcefe
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:17:28 2014 -0400

    Use rpm macros for standard paths

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit 8ef7f827e28e3cd284f6be5686a987786be7502d
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:16:16 2014 -0400

    This patch fixes the conversion of args for paltform-dump call.
    platform dump passes 64bit values as, a pair of 32bit values.
    val_hi and val_lo. So when we convert a value 'X' to 32bit hi and lo
    values in BE, we should follow the below approach :

    X_hi = htobe32(BITS32_HI(X))
    X_lo = htobe32(BITS32_LO(X))

    and NOT
    X_tmp = htobe64(X);
    X_hi = BITS32_HI(X_tmp), X_lo = BITS32_LO(X_tmp)

    This patch has been tested with rtas_errd/extract_platdump to retrieve a
    dump from FSP.

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit 52263814c46210b51e564748050299620726dfd1
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:12:54 2014 -0400

    Fix LE parsing of SRC/FRU events

    Signed-off-by: Thomas L Falcon <email address hidden>
    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit ac0a91d2730740cd279d80ccd4c83b0a04827d1d
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:10:29 2014 -0400

    LE Support for SRC/FRU events

    Signed-off-by: Nathan Fontenot <email address hidden>

@ Canonical,

We have recently made new upstream release (v1.3.13). If you are fine please pull new version.. -OR- just the patches mentioned here..

-Vasant

bugproxy (bugproxy)
tags: added: architecture-ppc64le bugnameltc-117928 severity-medium targetmilestone-inin1410
Luciano Chavez (lnx1138)
affects: ubuntu → librtas (Ubuntu)
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2014-11-11 11:11 EDT-------
librtas v 1.3.13

http://sourceforge.net/projects/librtas/files/librtas-1.3.13.tar.gz/download

-Vasant

bugproxy (bugproxy)
tags: added: targetmilestone-inin1504
removed: targetmilestone-inin1410
Adam Conrad (adconrad)
Changed in librtas (Ubuntu):
assignee: nobody → Adam Conrad (adconrad)
Changed in librtas (Ubuntu Utopic):
assignee: nobody → Adam Conrad (adconrad)
Changed in librtas (Ubuntu Trusty):
assignee: nobody → Adam Conrad (adconrad)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package librtas - 1.3.13-1

---------------
librtas (1.3.13-1) unstable; urgency=medium

  * New upstream release, with even more LE fixes (LP: #1391322)
  * debian/librtasevent1.symbols: Update for new 1.3.13 symbols.

 -- Adam Conrad <adconrad@0c3.net> Thu, 15 Jan 2015 08:23:08 -0700

Changed in librtas (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted librtas into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/librtas/1.3.13-1~14.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

description: updated
Changed in librtas (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello bugproxy, or anyone else affected,

Accepted librtas into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/librtas/1.3.13-1~14.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in librtas (Ubuntu Utopic):
status: New → Fix Committed
tags: added: verification-done
removed: verification-needed
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla
Download full text (7.2 KiB)

------- Comment From <email address hidden> 2015-01-26 14:49 EDT-------
I have just verified and the packages can be found in proposed for both
14.04 and 14.10. So it looks good for both repositories.
Thus we are now just awaiting for the final testing by the RAS team.

trusty:
# apt-cache madison libofdt-dev libofdt1 librtas-dev librtas1 librtasevent-dev librtasevent1
libofdt-dev | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources
libofdt1 | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources
librtas-dev | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources
librtas1 | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources
librtasevent-dev | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources
librtasevent1 | 1.3.13-1~14.04 | http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main ppc64el Packages
librtas | 1.3.13-1~14.04 | http://archive.ubuntu.com/ubuntu/ trusty-proposed/main Sources

# apt-get install libofdt-dev libofdt1 librtas-dev librtas1 librtasevent-dev librtasevent1
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
libofdt-dev libofdt1 librtas-dev librtas1 librtasevent-dev librtasevent1
0 upgraded, 6 newly installed, 0 to remove and 0 not upgraded.
Need to get 132 kB of archives.
After this operation, 792 kB of additional disk space will be used.
Get:1 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main librtas1 ppc64el 1.3.13-1~14.04 [22.2 kB]
Get:2 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main librtasevent1 ppc64el 1.3.13-1~14.04 [27.4 kB]
Get:3 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main libofdt1 ppc64el 1.3.13-1~14.04 [11.8 kB]
Get:4 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main libofdt-dev ppc64el 1.3.13-1~14.04 [10.6 kB]
Get:5 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main librtas-dev ppc64el 1.3.13-1~14.04 [23.5 kB]
Get:6 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main librtasevent-dev ppc64el 1.3.13-1~14.04 [36.4 kB]
Fetched 132 kB in 2s (47.2 kB/s)
Selecting previously unselected package librtas1.
(Reading database ... 46789 files and directories currently installed.)
Preparing to unpack .../librtas1_1.3.13-1~14.04_ppc64el.deb ...
Unpacking librtas1 (1.3.13-1~14.04) ...
Selecting previously unselected package librtasevent1.
Preparing to unpack .../librtasevent1_1.3.13-1~14.04_ppc64el.deb ...
Unpacking librtasevent1 (1.3.13-1~14.04) ...
Selecting previously unselected package libofdt1.
Preparing to unpack .../libofdt1_1.3.13-1~14.0...

Read more...

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package librtas - 1.3.13-1~14.04

---------------
librtas (1.3.13-1~14.04) trusty; urgency=medium

  * Straight backport to trusty for ppc64el hardware enablement.

librtas (1.3.13-1) unstable; urgency=medium

  * New upstream release, with even more LE fixes (LP: #1391322)
  * debian/librtasevent1.symbols: Update for new 1.3.13 symbols.
 -- Adam Conrad <email address hidden> Fri, 16 Jan 2015 09:28:42 -0700

Changed in librtas (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for librtas has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package librtas - 1.3.13-1~14.10

---------------
librtas (1.3.13-1~14.10) utopic; urgency=medium

  * Straight backport to utopic for ppc64el hardware enablement.

librtas (1.3.13-1) unstable; urgency=medium

  * New upstream release, with even more LE fixes (LP: #1391322)
  * debian/librtasevent1.symbols: Update for new 1.3.13 symbols.
 -- Adam Conrad <email address hidden> Fri, 16 Jan 2015 09:28:42 -0700

Changed in librtas (Ubuntu Utopic):
status: Fix Committed → Fix Released
bugproxy (bugproxy)
tags: removed: verification-done
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.