toolkit dialogs have wonky padding

[Matthew Paul Thomas]

Ubuntu 14.10 r135

1. Go to System Settings > "Wi-Fi".
2. If Wi-Fi is off, turn it on.
3. Scroll to the bottom of the list and choose "Connect to hidden network".

What you see: A dialog where the left padding (x1) is less than the right padding (x2), and the top padding (y1) is less than the bottom padding (y2).

What you should see: A dialog where the left and right padding are equal (x1 = x2), and the top and bottom padding are equal (y1 = y2).

I don't know whether this is a System Settings bug, a toolkit bug, or a combination.

[Sebastien Bacher (seb128)]

The x1/x2 difference is a toolkit issue for sure (the toolkit demo gallery has the same margins difference), it looks like the y1/y2 is as well but there might be some settings tweak as well then so keeping a component in low priority, to check again how are things looking once the uitk is fixed

[Sebastien Bacher (seb128)]

note that the title has the same issue, it's not correctly horizontally centered

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Tim Peeters (tpeeters)]

The contents of the dialog is horizontally centered (or should be), so that is a bug.

Vertically it goes directly under the title, so not vertically centered. To change that we'd need input from design.

[Sebastien Bacher (seb128)]

@Tim, right, the design document [1] has details about the position of the dialog but not about the spacing between its elements, I guess that's something for design to detail

[1] https://docs.google.com/a/canonical.com/document/edit?hgd=1&id=1nFm8xiYhKXXuEO_IvMXoD0lASbYzYXva1BWMVanU3iw#heading=h.7zj70oabnqs6

[Oliver Grawert (ogra)]

can we please have RTM tasks for both ? else we will miss when it lands in RTM

[Cris Dywan (kalikiana)]

I don't know what value these RTM tasks have… but there's a branch against RTM if anyone wants it.

[Cris Dywan (kalikiana)]

Quick reminder, the code is there.

[Selene ToyKeeper (toykeeper)]

FWIW, still fails on krillin rtm 176.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1298+15.04.20141203.1~rtm-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1298+15.04.20141203.1~rtm-0ubuntu1) 14.09; urgency=low

  [ Zoltán Balogh ]
  * Many TextField/TextArea fixes improving user experience greatly and
    making it more in line with the design: handle much easier to drag
    by making its touch area 4 grid units wide and centered around the
    cursor; double tapping anywhere (even around the handle) selects the
    word and opens the contextual menu; long pressing anywhere (even
    around the handle) selects the word and opens the contextual menu;
    make sure that when there is a selection the contextual menu is
    shown and shown above the cursor at the beginning of the selection;
    do not prevent other UI elements from receiving mouse/touch events
    when the contextual menu is shown
  * Revert to 1124
  * Fixed unit test
    tst_components::tst_textinput_touch::test_longtap_when_empty: do not
    cause a double tap before the long press.

  [ Christian Dywan ]
  * Don't subtract itemSpacing from column width (LP: #1387806)
 -- Ubuntu daily release <email address hidden> Wed, 03 Dec 2014 13:12:49 +0000

[Sebastien Bacher (seb128)]

the issue seems to be fixed in the current version