Instance-Delete Should Stop the Database First

[Auston McReynolds]

on instance-delete, the database should be stopped before deleting the nova compute.

why: if volumes are being used, delete_on_terminate today defaults to true (meaning if the compute is terminated, the volume is deleted). the phrase "the volume is deleted" means different things depending on the vendor you're using. for example, solidfire supports the ability to "undelete" a volume if done so within a specified window after deletion. if you're using such a vendor, you want the database properly stopped before deleting the server+volume to ensure that the data is a-ok for an undelete situation.

relevant code section: https://github.com/openstack/trove/blob/0007a5076aa795fc354b122ae591980c9413f054/trove/taskmanager/models.py#L846-L857

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129104

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129104
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=9a9477c2225ec05dc8f0a2e45fe0f4cdd0a33e7c
Submitter: Jenkins
Branch: master

commit 9a9477c2225ec05dc8f0a2e45fe0f4cdd0a33e7c
Author: amcrn <email address hidden>
Date: Thu Oct 16 18:32:55 2014 -0700

    Instance-Delete Should Stop the Database First

    on instance-delete, the database should be stopped before deleting
    the nova compute.

    Closes-Bug #1381174

    Change-Id: I94c2fa08be7faac37e1ac0a4460ad61f1f7ef164