Change the "Access permissions have changed" notification from a JS popup to an inline CSS thing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon |
Bug Description
One of the neat features we added in Mahara 1.10, was the ability to drag & drop pages into a collection.
However, we also added a Javascript popup that comes up with each dragged page, if the permissions for the page will change now that it's in the collection.
Example:
1. Create Page 1 & Page 2
2. Put Page 1 into Collection A
3. Set Collection A to be visible to the public
4. Drag Page 2 into Collection A
With all due respect, this notification is pretty annoying, and it kinda cancels out all the added utility that we got from implementing drag-and-drop, because often you have to click it after every single added page. (It also hurts our "number of clicks to get things done" metric.) And in Firefox if a page gives you JS pop-ups more than a few times, Firefox itself adds a tickbox to let you ignore further pop-ups, which I'm betting will confuse users and make them think their site is broken somehow.
If we must have a message telling users that the pages' permissions have changed, let's do it as an inline notice like the one you see on the Content -> Files page after you upload a file and it says "Upload of ___ complete". It shouldn't be green like that one, or red like an error notice. Perhaps the yellow "warning" styling that we use on the Admin Home page for site config warnings would be appropriate.
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
tags: | added: nominatedfeature |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
If possible, it would be good to consolidate the "permissions have changed" notices. Otherwise, as happens when you upload a lot of files to the file access page, it'll tend to scroll everything on the page down down down as they stack up.