Google Maps "my maps" URLs breaking

[Aaron Wells]

The Google Apps block is broken again!

As reported here: https://bugs.launchpad.net/mahara/+bug/1323495/comments/10

It breaks for (at least) these URLs:

https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

I think the common thread is that these are "my maps" URLs, which have "/ms" in them. We have a regex for that in the code, but it expects it to be a maps.google.* domain name instead of www.google.*

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/3778

[Eduardo (o-eduardo)]

Patch works and Tested on Mahara version 1.11.0dev (2014092500). Here is my full testing method:

1. Log in as admin
2. Go to Portfolio → Create page
3. Save
4. Click on External → Drag “Google Apps” block into the page
5. Paste link number 1
6. Save
7. Confirm Map is showing → Passed
8. Drag another “Google Apps” block into the page
9. Paste link number 2
10. Save
11. Confirm Map is showing → Passed
12. Drag another “Google Apps” block into the page
13. Paste link number 3
14. Save
15. Confirm Map is showing → Passed
16. Drag another “Google Apps” block into the page
17. Paste link number 4
18. Save
19. Confirm Maps is showing → Passed

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3778
Committed: http://gitorious.org/mahara/mahara/commit/4b1ce677aa4f37ffc46b1f9243c4b445be7f34de
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b1ce677aa4f37ffc46b1f9243c4b445be7f34de
Author: Son Nguyen <email address hidden>
Date: Thu Oct 9 10:48:07 2014 +1300

Handle more Google Maps URLs. Bug 1378645

This patch will convert these following share links into iframe embed
code

- https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

- https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

Change-Id: If1f31357de7c0476afa8ff7ec7e464bf33830fff

[Mahara Bot (dev-mahara)]

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3801

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3801
Committed: http://gitorious.org/mahara/mahara/commit/a50ee3bd91009ee228489d4e98bc0fbb100eaeb8
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit a50ee3bd91009ee228489d4e98bc0fbb100eaeb8
Author: Son Nguyen <email address hidden>
Date: Thu Oct 9 10:48:07 2014 +1300

Handle more Google Maps URLs. Bug 1378645

This patch will convert these following share links into iframe embed
code

- https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

- https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

Change-Id: If1f31357de7c0476afa8ff7ec7e464bf33830fff

[Mahara Bot (dev-mahara)]

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3802

[Mahara Bot (dev-mahara)]

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3803

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3802
Committed: http://gitorious.org/mahara/mahara/commit/a39299fdf686f5357bbbb7799e778eb56c19298b
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit a39299fdf686f5357bbbb7799e778eb56c19298b
Author: Son Nguyen <email address hidden>
Date: Thu Oct 9 10:48:07 2014 +1300

Handle more Google Maps URLs. Bug 1378645

This patch will convert these following share links into iframe embed
code

- https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

- https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

Change-Id: If1f31357de7c0476afa8ff7ec7e464bf33830fff

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3803
Committed: http://gitorious.org/mahara/mahara/commit/cebb431c23e48b0b7a260b1d69a13bb561acf417
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit cebb431c23e48b0b7a260b1d69a13bb561acf417
Author: Son Nguyen <email address hidden>
Date: Thu Oct 9 10:48:07 2014 +1300

Handle more Google Maps URLs. Bug 1378645

This patch will convert these following share links into iframe embed
code

- https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

- https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

- https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

Change-Id: If1f31357de7c0476afa8ff7ec7e464bf33830fff