The calendar picker is visible directly when adding someone to page access

Bug #1377542 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.10
Fix Released
High
Robert Lyon
15.04
Fix Released
High
Unassigned

Bug Description

1.10RC1

When adding someone to have access to a page, the calendar picker becomes visible directly because the focus is put onto the calendar field. I think this is not good because often you don't add a starting date for access to a page. Thus, you'll need to click out of the field to make the calendar go away.

What do others think?

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3752

Revision history for this message
Robert Lyon (robertl-9) wrote :

I feel that it needs to be changed - as the popup on focus is annoying when adding view access options

And seen it is an easy change handled by the datepicker UI, I'll make it only popup on the calendar icon

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → High
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3752
Committed: http://gitorious.org/mahara/mahara/commit/b1342fd74815df9a7c4c1bb7937a033215de24a6
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit b1342fd74815df9a7c4c1bb7937a033215de24a6
Author: Robert Lyon <email address hidden>
Date: Tue Oct 7 09:32:28 2014 +1300

Changed the datepicker popup from being on focus to being on icon click

Bug 1377542

Change-Id: I337937f432c46ee827b7aa69dd5be7ea3f448b14
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3776

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3776
Committed: http://gitorious.org/mahara/mahara/commit/9d8b0e868f47e7dc71616aac3ce4793a77dfa019
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 9d8b0e868f47e7dc71616aac3ce4793a77dfa019
Author: Robert Lyon <email address hidden>
Date: Tue Oct 7 09:32:28 2014 +1300

Changed the datepicker popup from being on focus to being on icon click

Bug 1377542

Change-Id: I337937f432c46ee827b7aa69dd5be7ea3f448b14
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.