Creating a "key" type order without a name set in "meta" produces a null when retrieved. Previously we populated
this value with the UUID of the secret. The expected behavior can be seen by creating a secret without a name attribute.
Steps to Reproduce:
-------
Create the order without a name attribute in meta:
curl -X POST -H "X-Auth-Token:$AUTH_TOKEN" -H "Content-Type:application/json" -H "X-Project-Id:$PROJECT_ID" -d '{
"type": "key",
"meta": {
"mode": "cbc",
"bit_length": 256,
"algorithm": "aes",
"payload_content_type": "application/octet-stream"
}
}' http://localhost:9311/v1/orders
Retrieve and inspect the resulting order:
curl -X GET -H "X-Auth-Token:$AUTH_TOKEN" -H "X-Project-Id:$PROJECT_TOKEN" http://localhost:9311/v1/orders/ed42542a-c8b4-405f-acb2-5fbddc9a2823
Reponse:
{
"created": "2014-10-01T21:31:40.963033",
"meta": {
"algorithm": "aes",
"bit_length": 256,
"expiration": null,
"mode": "cbc",
"name": null,
"payload_content_type": "application/octet-stream"
},
"order_ref": "http://localhost:9311/v1/orders/ed42542a-c8b4-405f-acb2-5fbddc9a2823",
"secret_ref": "http://localhost:9311/v1/secrets/2ccd16d6-54d3-4cfa-94b3-ea2d7386aa0a",
"status": "ACTIVE",
"type": "key",
"updated": "2014-10-01T21:31:41.315161"
}
Well, is adding the uuid as the name of the secret even the correct behavior? It seems that in the database, at least for secrets, the name is stored as empty, and only when the secret it's fetched then the id is set to the 'name' attribute: when there is a secret_
So, if the desired behavior is to have the secrets always with some sort of name, then we could start storing the uuid when the name is empty in the database; And the same would be done for orders. If this is not what we want, then I would say we should stop returning the uuid in the 'name' field for secrets and let the behavior that the orders have be the "desired" one. Any thoughts?