Errors in mailin don't abort the transaction

[Chris Rossi]

In testing mailin on staging I was able to corrupt the blog, a blog post was created and then exception was raise, and instead of rolling back the transaction, the transaction was committed, leading to a corrupt blog entry:

https://karlstaging.gocept.com/communities/a-time-for-testing-again/blog/might-as-well-test/

[Chris Rossi (chris-archimedeanco)]

Now that I look at this, this doesn't have to do with karlserveless. It's been latent in Karl for some time. Basically when we put messages in the quarantine, because they have an exception for some reason, we don't do anything to roll back the work that might have been done before we hit the exception. We don't want to abort the entire transaction, since that would defeat the point of moving messages to the quarantine. And, of course, moving messages to the quarantine is part of the transaction. It might make sense to start using savepoints, though, and roll back to a savepoint made before attempting to process a message, before moving the message to the quarantine. I've never been superclear how well savepoints work in ZODB. Will look into it.

[Paul Everitt (paul-agendaless)]

Very good job on the diagnosis.

--Paul

On Sep 30, 2014, at 4:09 PM, Chris Rossi <email address hidden> wrote:

> Now that I look at this, this doesn't have to do with karlserveless.
> It's been latent in Karl for some time. Basically when we put messages
> in the quarantine, because they have an exception for some reason, we
> don't do anything to roll back the work that might have been done before
> we hit the exception. We don't want to abort the entire transaction,
> since that would defeat the point of moving messages to the quarantine.
> And, of course, moving messages to the quarantine is part of the
> transaction. It might make sense to start using savepoints, though, and
> roll back to a savepoint made before attempting to process a message,
> before moving the message to the quarantine. I've never been superclear
> how well savepoints work in ZODB. Will look into it.
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/1375884
>
> Title:
> Errors in mailin don't abort the transaction
>
> Status in KARL3:
> In Progress
>
> Bug description:
> In testing mailin on staging I was able to corrupt the blog, a blog
> post was created and then exception was raise, and instead of rolling
> back the transaction, the transaction was committed, leading to a
> corrupt blog entry:
>
> https://karlstaging.gocept.com/communities/a-time-for-testing-
> again/blog/might-as-well-test/
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1375884/+subscriptions

[Paul Everitt (paul-agendaless)]

I'm going to move this out of the way for now. I'd like us to wrap up some of the KARL4 ideas while we're in the mode of cleanup.