[TOPBLOCKER] Threading issue with the MenuModel Updates

[Mathieu Trudel-Lapierre]

This and other "corruptions" in the i-network menus is caused by a race condition in the i-network-service GMainLoop synchronization.

===
Some access points in indicator-network show twice, when they should be merged into a single entry given that security and SSID are the same.

See attached screenshot.

For example, "Instant Staff" should only show once, not greyed out. There are not multiple APs with different security settings to justify two different entries.

[Mathieu Trudel-Lapierre (cyphermox)]

This bug also affects ubuntu-system-settings wifi screen; I've attached the screenshot that shows this issue.

[Mathieu Trudel-Lapierre (cyphermox)]

Example scan list.

SSID BSSID MODE FREQ RATE SIGNAL SECURITY ACTIVE
'Canonical-2.4GHz-g' <redacted> Infrastructure 2462 MHz 54 MB/s 92 WPA2 no
'Canonical-2.4GHz-g' <redacted> Infrastructure 2437 MHz 54 MB/s 87 WPA2 no
'Canonical-2.4GHz-g' <redacted> Infrastructure 2437 MHz 54 MB/s 80 WPA2 no
'Ruckus-Wireless-1' <redacted> Infrastructure 2462 MHz 54 MB/s 39 WPA WPA2 no
'Masterchef @ BFV' <redacted> Infrastructure 2462 MHz 54 MB/s 37 WPA WPA2 no
'MChef Guest' <redacted> Infrastructure 2462 MHz 54 MB/s 37 -- no
'COGUEST' <redacted> Infrastructure 2437 MHz 54 MB/s 27 -- no
'COMOB' <redacted> Infrastructure 2412 MHz 54 MB/s 35 WPA2 Enterprise no
'COGUEST' <redacted> Infrastructure 2412 MHz 54 MB/s 34 -- no
'Instant Staff' <redacted> Infrastructure 2417 MHz 54 MB/s 22 WPA2 no
'DATAGuest' <redacted> Infrastructure 2462 MHz 54 MB/s 24 -- no
'COWF' <redacted> Infrastructure 2412 MHz 54 MB/s 34 WPA2 Enterprise no
'Instant Setup' <redacted> Infrastructure 2417 MHz 54 MB/s 22 -- no
'Instant Guest' <redacted> Infrastructure 2417 MHz 54 MB/s 22 -- no
'Canonical-2.4GHz-g' <redacted> Infrastructure 2412 MHz 54 MB/s 80 WPA2 yes
'COMOB' <redacted> Infrastructure 2437 MHz 54 MB/s 27 WPA2 Enterprise no
'IPCDev' <redacted> Infrastructure 2462 MHz 54 MB/s 20 WPA2 no
'TableauGuest' <redacted> Infrastructure 2462 MHz 54 MB/s 15 WPA2 no
'JustWireless' <redacted> Infrastructure 2472 MHz 54 MB/s 15 WPA2 no
'Ruckus-Wireless-1' <redacted> Infrastructure 2427 MHz 54 MB/s 30 WPA WPA2 no
'TSILAKEVIEW' <redacted> Infrastructure 2412 MHz 54 MB/s 15 WPA2 Enterprise no

[Mathieu Trudel-Lapierre (cyphermox)]

This was tested with Silo 11 on image 61.

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-======================-========================================-============-=================================================
ii indicator-network 0.5.1+14.10.20140925.1-0ubuntu1 armhf Systems settings menu service - Network indicator
ii ubuntu-system-settings 0.3+14.10.20140924-0ubuntu1 armhf System Settings application for Ubuntu Touch
ii urfkill 0.6.0~20140923.183149.c5012c3.1-0ubuntu1 armhf wireless killswitch management daemon for laptops

[Matthew Paul Thomas (mpt)]

There might be multiple bugs here.

The scan list shows "COGUEST" twice, but it is correctly shown only once in the screenshots. Meanwhile, the scan list shows "Canonical-2.4GHz-g" four times, but it is shown twice in the screenshots -- not once, but not four times either.

I think that problem might be that the list is showing the currently-connected network first, and then listing all available networks, instead of listing all *other* available networks. That is, it forgets to exclude the current network from the second part of the list.

However, none of that would explain why "Instant Staff" shows up only once in the scan list but ends up with two items in the screenshots.

[Antti Kaijanmäki (kaijanmaki)]

Was this with the URfkill silo?

Seems like the menumodel being out of sync. The greyed out item should never appear as it means the item does not have an Action attached to it.

I would need a full dump of iwlist scan when you see access points that are not merged properly. Thanks!

[Antti Kaijanmäki (kaijanmaki)]

Marking as invalid for system-settings as the access point list is coming from i-network.

[Mathieu Trudel-Lapierre (cyphermox)]

You already have the scan list, from NetworkManager. The same list would come from iw. I can't get you the list anymore, since I'm no longer in the same location, but the list of networks is already available.

[Brendan Donegan (brendan-donegan)]

I also see APs twice with the following test case:

Prerequisite: Make sure you are already connected to a network
1. Open the network indicator
2. Select another network to connect to
3. Cancel the snap decision
4. Check the AP list, the previously selected AP will be shown twice and selected each time.

I feel this is a different bug than the one mentioned here but Antii says otherwise, so for now I'm just adding this comment.

[Selene ToyKeeper (toykeeper)]

Bug 1362296 is probably a dupe of this, and has extra screenshots and details for reproducing the issue in the welcome wizard.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-network - 0.5.1+15.04.20141103-0ubuntu1

---------------
indicator-network (0.5.1+15.04.20141103-0ubuntu1) vivid; urgency=low

  [ CI bot ]
  * Resync trunk

  [ Jussi Pakkanen ]
  * Use std::quick_exit. (LP: #1381041)

  [ Marcus Tomlinson ]
  * Fix GMainLoopDispatch dispatching ordering when. called inside
    GMainLoop already Fix GMainLoopDispatch locking. Force all signals
    from external (dbus-cpp) threads through. GMainLoopDispatch (LP:
    #1374419)

  [ Antti Kaijanmäki ]
  * Increase the default timeouts to match industry standards. (LP:
    #1381041)
  * Fix GMainLoopDispatch dispatching ordering when. called inside
    GMainLoop already Fix GMainLoopDispatch locking. Force all signals
    from external (dbus-cpp) threads through. GMainLoopDispatch (LP:
    #1374419)

indicator-network (0.5.1+14.10.20141015-0ubuntu1) 14.09; urgency=low

  [ Antti Kaijanmäki ]
  * deadlock if calling unlock() inside ready signal for a modem that
    does not require unlocking. (LP: #1333121)
 -- Ubuntu daily release <email address hidden> Mon, 03 Nov 2014 11:48:11 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-network - 0.5.1+14.10.20141031.3~rtm-0ubuntu1

---------------
indicator-network (0.5.1+14.10.20141031.3~rtm-0ubuntu1) 14.09; urgency=low

  [ Jussi Pakkanen ]
  * Use std::quick_exit. (LP: #1381041)

  [ Marcus Tomlinson ]
  * Fix GMainLoopDispatch dispatching ordering when. called inside
    GMainLoop already Fix GMainLoopDispatch locking. Force all signals
    from external (dbus-cpp) threads through. GMainLoopDispatch (LP:
    #1374419)

  [ Antti Kaijanmäki ]
  * Increase the default timeouts to match industry standards. (LP:
    #1381041)
  * Fix GMainLoopDispatch dispatching ordering when. called inside
    GMainLoop already Fix GMainLoopDispatch locking. Force all signals
    from external (dbus-cpp) threads through. GMainLoopDispatch (LP:
    #1374419)
 -- Ubuntu daily release <email address hidden> Fri, 31 Oct 2014 14:16:08 +0000