Address bar text can get overwritten if page loads whilst editing
Bug #1373918 reported by
Michael Sheldon
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Olivier Tilloy | ||
webbrowser-app |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu RTM) |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
Steps to reproduce
1. Start loading a new page
2. Whilst loading edit the address bar, replacing the text with something new
3. Wait for original page to finish loading
Expected result
Text the user entered should be preserved
Actual result
When the page starts to load the address bar text gets replaced with the new URL.
This is easiest to see on slow connections as the change happens early in the loading process.
I suspect this could be fixed by checking that addressbar.state isn't "editing" in AddressBar's onActualUrlChanged handler.
Related branches
lp:~osomon/webbrowser-app/editing-while-loading
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Michael Sheldon (community): Approve
-
Diff: 249 lines (+26/-59)4 files modifiedsrc/app/webbrowser/AddressBar.qml (+15/-28)
src/app/webbrowser/Chrome.qml (+2/-5)
tests/autopilot/webbrowser_app/tests/test_addressbar_states.py (+9/-16)
tests/unittests/qml/tst_AddressBar.qml (+0/-10)
lp:~osomon/webbrowser-app/rtm-14.09-editing-while-loading
- Ubuntu Phablet Team: Pending requested
-
Diff: 252 lines (+28/-58)4 files modifiedsrc/app/webbrowser/AddressBar.qml (+16/-26)
src/app/webbrowser/Chrome.qml (+3/-6)
tests/autopilot/webbrowser_app/tests/test_addressbar_states.py (+9/-16)
tests/unittests/qml/tst_AddressBar.qml (+0/-10)
Changed in webbrowser-app: | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
assignee: | nobody → Michael Sheldon (michael-sheldon) |
Changed in canonical-devices-system-image: | |
milestone: | none → ww05-2015 |
importance: | Undecided → Medium |
Changed in canonical-devices-system-image: | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
assignee: | Michael Sheldon (michael-sheldon) → Olivier Tilloy (osomon) |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | New → Confirmed |
Changed in webbrowser-app (Ubuntu): | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in webbrowser-app (Ubuntu RTM): | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
this is quite annoying, happens to me all the time.