SmartScopesProxy needs to send version numbers to the server
Bug #1372834 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
| Utopic |
Won't Fix
|
Undecided
|
Unassigned | ||
| unity-scopes-shell (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
Bug Description
Shell plugin needs to report versions of important components (scopes-api, shell-plugin and unity8) with search and preview request, and they need to be passed to from SmartScopesProxy to Smart Scopes Server via UserAgent string.
Related branches
lp:~stolowski/unity-scopes-shell/send-user-agent
- Pete Woods (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 247 lines (+115/-11)5 files modifiedsrc/Unity/previewstack.cpp (+5/-1)
src/Unity/previewstack.h (+2/-1)
src/Unity/scope.cpp (+6/-1)
src/Unity/scopes.cpp (+94/-8)
src/Unity/scopes.h (+8/-0)
lp:~stolowski/unity-scopes-api/user-agent
- PS Jenkins bot (community): Approve (continuous-integration)
- Michi Henning (community): Approve
- Pete Woods: Pending requested
-
Diff: 383 lines (+113/-17)11 files modifiedSTRUCTS (+19/-0)
include/unity/scopes/internal/smartscopes/HttpClientInterface.h (+6/-1)
include/unity/scopes/internal/smartscopes/HttpClientQt.h (+4/-2)
include/unity/scopes/internal/smartscopes/HttpClientQtThread.h (+4/-1)
include/unity/scopes/internal/smartscopes/SmartScopesClient.h (+3/-1)
src/scopes/internal/smartscopes/HttpClientQt.cpp (+7/-5)
src/scopes/internal/smartscopes/HttpClientQtThread.cpp (+6/-1)
src/scopes/internal/smartscopes/SmartScope.cpp (+16/-3)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+18/-2)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/FakeSss.py (+3/-0)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+27/-1)
| Changed in unity-scopes-shell: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-api (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| summary: |
- Shell plugin needs to send version numbers to scopes + SmartScopesProxy needs to send version numbers to the server |
| description: | updated |
| description: | updated |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | New → Confirmed |
| Changed in unity-scopes-shell: | |
| status: | Confirmed → In Progress |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | Confirmed → In Progress |
| tags: | added: touch-2014-10-09 |
| Changed in unity-scopes-api (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| no longer affects: | unity-scopes-shell |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity-scopes-api (Ubuntu Utopic): | |
| status: | New → Won't Fix |
To post a comment you must log in.
This bug was fixed in the package unity-scopes-shell - 0.5.4+14.
---------------
unity-scopes-shell (0.5.4+
[ Pete Woods ]
* Remove missing departments (LP: #1354362)
[ Pawel Stolowski ]
* Remove missing departments (LP: #1354362)
* Iterate over temprary dash pages of every scope to find matching
scope when dbus signal for results invalidation was received. This
is only done if there was no match among favorite scopes. (LP:
#1365544)
* Fix signature of the deleteLater slot when scheduling scope for
removal after un-favoriting.
* Send build number, release name and package versions of unity8,
shell plugin and scopes api with user-agent hint in SearchMetadata
and PreviewMetadata. (LP: #1372834)
[ Marcus Tomlinson ]
* Handle "scopes" scope invalidation by re-populating the overview
scope. (LP: #1375718)
-- Ubuntu daily release <email address hidden> Thu, 02 Oct 2014 07:18:26 +0000