download checkbox shown as already ticked on folder block when first enabled

[Robert Lyon]

when you enable the download folder as zip option in extensions -> folder -> configuration and then go to edit an existing folder block the download as zip option is already ticked - this shouldn't be the case - it should be opt in rather than opt out

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/3706

[Steven (stevens-q)]

=== Prerequisites ===

1. Folder downloads -> Download folders as a zip file - check box is NOT ticked

2. You must log in as admin for the site

=== How to Test ===
1. create a portfolio page that has a folder block on it

2. confirm that you do NOT see a Show download link tick box displayed ✔

3. save the block and click done on the portfolio page

4. browse to Administration -> extensions -> (Plugin type: blocktype)- file/folder -> configuration -> tick the check box for "Download folders as a zip file"

5. browse back to and edit the portfolio page folder block

6. confirm that the "Show download link tick box" is displayed and is not ticked ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3706
Committed: http://gitorious.org/mahara/mahara/commit/d02d83b30b33c2a40b4241cda57e5b133e580732
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d02d83b30b33c2a40b4241cda57e5b133e580732
Author: Robert Lyon <email address hidden>
Date: Thu Sep 18 15:38:32 2014 +1200

Making the checkbox opt in (Bug #1370830)

Have it display as checked only if one has saved that state previously

Change-Id: I11620d1b1b1dea25165b1d0e6fbea95cfaede6db
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3763

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3763
Committed: http://gitorious.org/mahara/mahara/commit/47fe326b5bd113c6fd1e9e546e4d8a56e2f315bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 47fe326b5bd113c6fd1e9e546e4d8a56e2f315bc
Author: Robert Lyon <email address hidden>
Date: Thu Sep 18 15:38:32 2014 +1200

Making the checkbox opt in (Bug #1370830)

Have it display as checked only if one has saved that state previously

Change-Id: I11620d1b1b1dea25165b1d0e6fbea95cfaede6db
Signed-off-by: Robert Lyon <email address hidden>