[Unity Dependency] Cleanup workarounds made to accept any QObject as Action or ActionContext.
Bug #1369874 reported by
Zsombor Egri
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Cris Dywan | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
We must introduce workarounds in toolkit to accept any QObject as Action or ActionContext to avoid crashes on those apps who mix Unity Actions with Toolkit Actions on registration.
Related branches
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noDoCleanup
- Zsombor Egri: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 479 lines (+70/-158)6 files modifiedcomponents.api (+10/-10)
modules/Ubuntu/Components/plugin/ucactioncontext.cpp (+16/-35)
modules/Ubuntu/Components/plugin/ucactioncontext.h (+7/-7)
modules/Ubuntu/Components/plugin/ucactionmanager.cpp (+23/-60)
modules/Ubuntu/Components/plugin/ucactionmanager.h (+14/-14)
tests/unit/tst_components/tst_action.qml (+0/-32)
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
tags: |
added: 1.2 removed: toolkit1.2 |
affects: | ubuntu-ui-toolkit → ubuntu-ui-toolkit (Ubuntu) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Christian Dywan (kalikiana) |
status: | Won't Fix → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
any QObject? Shouldn't we at least check the interface of the QObject used?