[Unity Dependency] Cleanup workarounds made to accept any QObject as Action or ActionContext.

Bug #1369874 reported by Zsombor Egri
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Medium
Cris Dywan
Vivid
New
Undecided
Unassigned

Bug Description

We must introduce workarounds in toolkit to accept any QObject as Action or ActionContext to avoid crashes on those apps who mix Unity Actions with Toolkit Actions on registration.

Tags: 1.2

Related branches

Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Cris Dywan (kalikiana)
tags: added: 1.2
removed: toolkit1.2
Revision history for this message
Tim Peeters (tpeeters) wrote :

any QObject? Shouldn't we at least check the interface of the QObject used?

Revision history for this message
Tim Peeters (tpeeters) wrote :

which apps use unity actions?

Revision history for this message
Tim Peeters (tpeeters) wrote :

the unity dependency was removed >1month ago, and there are no problems with this. Closing the bug.

Changed in ubuntu-ui-toolkit:
status: Confirmed → Won't Fix
Zsombor Egri (zsombi)
affects: ubuntu-ui-toolkit → ubuntu-ui-toolkit (Ubuntu)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Christian Dywan (kalikiana)
status: Won't Fix → In Progress
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1584+15.10.20150730-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1584+15.10.20150730-0ubuntu1) wily; urgency=medium

  [ Florian Boucault ]
  * New BottomEdgeHint component to represent extra features available from the
    bottom edge of an application.

  [ Loïc Molinari ]
  * [UbuntuShape] Added a big radius.
  * [UbuntuShape] Added relative radius support. Fixes LP: #1478124.
  * Ensured components, styles, examples and tests use the new UbuntuShape
    properties (not deprecated). Fixes LP: #1437412.

  [ Benjamin Zeller ]
  * Make use of the official qt build macros to blend into the Qt buildprocess.
  * Fix debug builds, optimization is always enabled by the system qt build.

  [ Richard Huddie ]
  * Fix for autopilot bug lp:1476715. Don't throw an exception if maliit-server
    is not found. Fixes LP: #1476715.

  [ Tim Peeters ]
  * Clean up the MainView docs.
  * Set theme version for Sections component.
  * Implement AdaptivePageLayout.

  [ Zsombor Egri ]
  * Fix width for trailing and leading actions of a ListItem. Fixes LP: #1465582.
  * Button and Haptics import wrong toolkit versions, thus they break style
    versioning. Moving Icon and ProgressBar to 1.0 and 1.1 version source folder.
  * SuruDark theme for ListItem style. Fixes LP: #1451225.
  * Swiping ListItem when no actions are defined for the gesture breaks
    selectMode. Fixes LP: #1468100.
  * Fixing selected connection with the ListItem's select mode checkbox state.
    Fixes LP: #1461501, LP: #1469471.

  [ Timo Jyrinki ]
  * Fix ucstylehints.cpp compilation with Qt 5.5. Fixes LP: #1473873.
  * Add PageHeadStyle 1.3 reference to fix install_plugins_qmltypes failure with
    Qt 5.5. Fixes LP: #1466484.

  [ Christian Dywan ]
  * Avoid hard-coded skipping of members by name "type" can be a property name
    regardless of also being a field in the JSON description of a property.
  * Add apicheck unit test for QML and Javascript.
  * Remove "do cleanup" comments. Fixes LP: #1369874.
  * Initialize defaultTypes later to avoid bogus types.
  * Implement Action.shortcut property. Fixes LP: #1202464.
  * Update text handler to 3gu assert.
  * Add a deprecated note to ListItems.ThinDivider. Fixes LP: #1470951.
  * Don't include overridden properties in API.
  * Clean-up API check wrapper scripts.
  * Track version members were introduced.
  * Implement ListItemPopover on right-click. Fixes LP: #1452676.
  * Move delegate's chevron into the row and size it explicitly.
    Fixes LP: #1474418.
  * Enable (Shift)Tab via activeFocusOnTab. Fixes LP: #1276797.
  * Only swipe with left button and block timer otherwise.
    Fixes LP: #1476300, LP: #1476310.
  * Include Javascript libraries in QML documentation. Fixes LP: #1466058.

  [ Albert Astals Cid ]
  * Fix warning if there's no __propagated
  * TypeError: Cannot call method 'hasOwnProperty' of null.

 -- CI Train Bot <email address hidden> Thu, 30 Jul 2015 13:04:18 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.