taskflow

Mismatch error 'REVERTED' != 'FAILURE'

Bug #1365830 reported by Joshua Harlow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
taskflow
Fix Released
High
Joshua Harlow
taskflow 0.7.0

Bug Description

It seems like we can hit 'REVERTED' != 'FAILURE' in the taskflow.tests.unit.conductor.test_conductor.SingleThreadedConductorTest.test_fail_run test due to a atom detail that should exist in the memory backend not existing, this causes the test to fail periodically.

See original description
Joshua Harlow (harlowja)
Changed in taskflow:
importance: Undecided → High
Joshua Harlow (harlowja)
Changed in taskflow:
assignee: nobody → Joshua Harlow (harlowja)
Joshua Harlow (harlowja)
Changed in taskflow:
status: New → In Progress
Joshua Harlow (harlowja)
Changed in taskflow:
milestone: none → next-juno
Doug Hellmann (doug-hellmann)
Changed in taskflow:
milestone: next-juno → next-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124242

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on taskflow (master)

Change abandoned by Joshua Harlow (<email address hidden>) on branch: master
Review: https://review.openstack.org/119291
Reason: Abandoned in favor of https://review.openstack.org/#/c/124242/

Joshua Harlow (harlowja)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124552

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on taskflow (master)

Change abandoned by Joshua Harlow (<email address hidden>) on branch: master
Review: https://review.openstack.org/124242
Reason: Moved to https://review.openstack.org/#/c/124552/ which is nicer.

Joshua Harlow (harlowja)
summary: - Mistmatch error 'REVERTED' != 'FAILURE'
+ Mismatch error 'REVERTED' != 'FAILURE'
Joshua Harlow (harlowja)
Changed in taskflow:
milestone: 0.6.0 → none
milestone: none → next-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/124552
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=84b387f8bb56d7c03dbe56a84ddbad94bf46262e
Submitter: Jenkins
Branch: master

commit 84b387f8bb56d7c03dbe56a84ddbad94bf46262e
Author: Joshua Harlow <email address hidden>
Date: Thu Sep 25 18:27:05 2014 -0700

    Rework the in-memory backend

    This avoids storing direct copies of incoming objects and
    makes sure that we always merge incoming objects (if a
    saved object already exists) or create a copy of the
    incoming object if it does not exist when storing.

    On retrieval we also always return copies instead of
    returning the data that is stored internally to avoid the
    problems that can be hard to detect when users (engine
    or other) modify those source objects.

    Fixes bug 1365830

    Also fixes a retry test case issue that was discovered due
    to this more easily useable/understandable memory backend
    changes...

    Change-Id: I2afdda7beb71e35f7e12d9fd7ccf90b6c5447274

Changed in taskflow:
status: In Progress → Fix Committed
Joshua Harlow (harlowja)
Changed in taskflow:
milestone: none → 0.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.