ipv6 tests leave ipv6 flag disabled

[Kevin Benton]

The test_disabled test for the IPv6 utilities leaves a module level flag set to disabled, which will break any following tests that depend on IPv6 being enabled (e.g. the iptables tests).

http://logs.openstack.org/49/113749/8/check/gate-neutron-python27/8787946/console.html

To reproduce, you can run these two tests serially.

neutron.tests.unit.test_ipv6.TestIsEnabled.test_disabled
neutron.tests.unit.test_security_groups_rpc.TestSecurityGroupAgentEnhancedRpcWithIptables.test_prepare_remove_port

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119288

[Kevin Benton (kevinbenton)]

looks like this has hit several things in the gate

http://logstash.openstack.org/#eyJzZWFyY2giOiIgbWVzc2FnZTpcIkZBSUw6IG5ldXRyb24udGVzdHMudW5pdC50ZXN0X3NlY3VyaXR5X2dyb3Vwc19ycGMuVGVzdFNlY3VyaXR5R3JvdXBBZ2VudEVuaGFuY2VkUnBjV2l0aElwdGFibGVzLnRlc3RfcHJlcGFyZV9yZW1vdmVfcG9ydFwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiIxNzI4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sIm1vZGUiOiIiLCJhbmFseXplX2ZpZWxkIjoiIiwic3RhbXAiOjE0MDk4OTYyNzg1NzV9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119358

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119288
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aa2f70844280c5c9aaaba76de3d98d4f7d6856af
Submitter: Jenkins
Branch: master

commit aa2f70844280c5c9aaaba76de3d98d4f7d6856af
Author: Kevin Benton <email address hidden>
Date: Thu Sep 4 21:55:47 2014 -0700

    Reset IPv6 detection flag after IPv6 tests

    Resets a module level flag that was being left in the
    state that the previous test set it to. This was causing
    unrelated tests to fail if the last state was left disabled.

    Closes-Bug: #1365829
    Change-Id: Id3f6cb680f5d832e21966de7d4fa335c0c59697c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119358
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=74a292ceba0be6aaa7ea1911cac2f102eb3db90e
Submitter: Jenkins
Branch: master

commit 74a292ceba0be6aaa7ea1911cac2f102eb3db90e
Author: Miguel Angel Ajo <email address hidden>
Date: Fri Sep 5 14:10:35 2014 +0200

    Avoid testing code duplication which introduced testing bugs

    SecurityGroupAgentEnhancedRpcTestCase duplicated code in
    SecurityGroupAgentRpcTestCase setUp, also
    TestSecurityGroupAgentEnhancedRpcWithIptables duplicated
    code from TestSecurityGroupAgentWithIptables setUp()
    introducing bugs by improper initialization, like a missing
        self.iptables.use_ipv6 = True
    which in combination with tests.unit.test_ipv6.TestIsEnabled
    produced inconsistent testing results.

    Change-Id: Ic0b596b6fe1d8273df197e9426abad818832c00a
    Closes-bug: #1365829