ubuntu 12.04.5 broken on VMware

[Thomas Hellström]

[Impact]

A user might find Ubuntu 12.04.5 unusable on vmware because he would face a black screen after logging in. Although there is a workaround (disabling 3D) a user may have given up at that point.

Backporting will help the user run the distro after upgrading, so I believe it's highly justified.

[Test Case]

On VMware Workstation 10, Install Ubuntu 12.04.5, preferrably using "easy install".
Boot the VM, log in. You'll see a black screen only.

[Regression Potential]

The bug affects a function that impots a shared buffer to the 3D driver. The function is completely broken by the bug. Even if the patch should introduce another type of breakage, the problem couldn't be much worse than it already is, and should be confined to the specific function in question.

[Other info]

Due to different stack ordering of automatic variables, the bug may or may not be visible depending on the C compiler and the level of optimization used. For example, if -O0 -g is used the bug is not visible on 12.04.5. I have not encountered any symptoms of the bug yet on 14.04.

[ Original bug report ]
Ubuntu 12.04.5 shows a black screen after login with 3D enabled on
VMware. This is due to a bug in the svga gallium driver's winsys.

It's recently fixed in mesa master commit 2d6206140a, "winsys/svga: Fix
incorrect type usage in IOCTL v2", with a request to backport to mesa
stable, but I'm not sure whether anyone's still maintaining the 10.1 branch.

Due to the severity of the symptoms it would be greatly appreciated if
this fix could be incorporated in the
libgl1-mesa-dri-lts-trusty package as soon as possible.

Unfortunately it's affecting the package on the installation iso. Is there anything that can be done about that?

Thanks,
Thomas

[Maarten Lankhorst (mlankhorst)]

This has been fixed in utopic by moving to mesa 10.3.

mesa-lts-trusty and mesa in trusty are still affected, I'll prepare a fix for them.

I don't think the images can be redone. The trusty 14.04.2 dvd will have the utopic stack which will be fixed, but precise will no longer have new iso's.

Could you update the bug description with the template linked below?
https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

[Thomas Hellström (thellstrom)]

[Impact]

A user might find Ubuntu 12.04.5 unusable on vmware because he would face a black screen after logging in. Although there is a workaround (disabling 3D) a user may have given up at that point.

Backporting will help the user run the distro after upgrading, so I believe it's highly justified.

[Test Case]

On VMware Workstation 10, Install Ubuntu 12.04.5, preferrably using "easy install".
Boot the VM, log in. You'll see a black screen only.

[Regression Potential]

The bug affects a function that impots a shared buffer to the 3D driver. The function is completely broken by the bug. Even if the patch should introduce another type of breakage, the problem couldn't be much worse than it already is, and should be confined to the specific function in question.

[Other info]

Due to different stack ordering of automatic variables, the bug may or may not be visible depending on the C compiler and the level of optimization used. For example, if -O0 -g is used the bug is not visible on 12.04.5. I have not encountered any symptoms of the bug yet on 14.04.

[Chris J Arges (arges)]

Maarten please fix your upload (comments should be in the rejection email) and ping an SRU team member to review when this is re-uploaded.
Thanks

[Maarten Lankhorst (mlankhorst)]

Hey,

The package correctly mentions utopic, see this package in -updates:

https://launchpad.net/ubuntu/+source/mesa/10.1.3-0ubuntu0.1

Unfortunately I mistakenly uploaded a git snapshot at one point to ubuntu instead of a ppa, so it generates a debdiff not against 10.1.3-0ubuntu0.1, but against that git snapshot.

I'll attach a debdiff against 10.1.3-0ubuntu0.1 to this bug, and re-upload it again.

~Maarten

[Chris J Arges (arges)]

Hello Thomas, or anyone else affected,

Accepted mesa into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/mesa/10.1.3-0ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Thomas Hellström (thellstrom)]

Chris, perhaps you can help me a bit by explaining here:

The buggy package in Ubuntu 12.04.5 that was on the installation iso and
that I rebuilt locally with the fix before filing the bug was called
mesa-lts-trusty. How does that relate to this package?

Thanks,
Thomas

On 10/01/2014 02:04 PM, Chris J Arges wrote:
> Hello Thomas, or anyone else affected,
>
> Accepted mesa into trusty-proposed. The package will build now and be
> available at http://launchpad.net/ubuntu/+source/mesa/10.1.3-0ubuntu0.2
> in a few hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://urldefense.proofpoint.com/v1/url?u=https://wiki.ubuntu.com/Testing/EnableProposed&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=6i%2FG3qEpVSz8wL%2FaiY%2Fao74%2BAoL8VMn%2FCrCnQHHkDGo%3D%0A&s=58e37f56b443c106798395284093c1e9afddd26cc0cbb6e15640474c2a568035 for documentation how to
> enable and use -proposed. Your feedback will aid us getting this update
> out to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, and change the tag
> from verification-needed to verification-done. If it does not fix the
> bug for you, please add a comment stating that, and change the tag to
> verification-failed. In either case, details of your testing will help
> us make a better decision.
>
> Further information regarding the verification process can be found at
> https://urldefense.proofpoint.com/v1/url?u=https://wiki.ubuntu.com/QATeam/PerformingSRUVerification&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=6i%2FG3qEpVSz8wL%2FaiY%2Fao74%2BAoL8VMn%2FCrCnQHHkDGo%3D%0A&s=46ffdc6903022c90f2b6c585f15547ddcf9fc50d556dd1d691512bd9d759bd7e . Thank you in
> advance!
>
> ** Changed in: mesa (Ubuntu Trusty)
> Status: Incomplete => Fix Committed
>
> ** Tags added: verification-needed
>

[Robert Hooker (sarvatt)]

The package has to be accepted into trusty before it can be backported to the trusty stack on precise

[Maarten Lankhorst (mlankhorst)]

I attached a debdiff for lts-trusty, rest of xorg team is away this week, so I've subscribed ubuntu-sponsors :)

[Thomas Hellström (thellstrom)]

The problem is I can't verify the bug is fixed in trusty because it doesn't show any obvious symptoms.
This is probably due to different stack ordering of local variables compared to the trusty stack on precise.

The only way to verify the fix is in the trusty stack on precise where the bug is very obvious...

/Thomas

[Thomas Hellström (thellstrom)]

Hi!

I now enabled proposed in Ubuntu 14.04 and did a full update:
dpkg -s libgl1-mesa-dri says
Version: 10.1.3-0ubuntu0.2
No sign of the bug symptoms. Everything working as expected.

I also enabled proposed in Ubuntu 12.04.5 and did a full update:
dpgk -s libgl1-mesa-dri-lts-trusty says
Version: 10.1.3-0ubuntu0.1~precise1
The bug is still present.

so please, if possible publish a proposed package also for Ubuntu 12.04.5

Thanks,
Thomas

[Brian Murray (brian-murray)]

Hello Thomas, or anyone else affected,

Accepted mesa-lts-trusty into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/mesa-lts-trusty/10.1.3-0ubuntu0.2~precise1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package mesa - 10.1.3-0ubuntu0.2

---------------
mesa (10.1.3-0ubuntu0.2) trusty; urgency=medium

  [ Timo Aaltonen ]
  * Drop fix-kwin.diff hack, as 10.1.3 has 0380ec467d78f40 which
    fixes the issue properly.

  [ Maarten Lankhorst ]
  * Add fix-svga-ioctl.patch (LP: #1365490)
 -- Maarten Lankhorst <email address hidden> Tue, 30 Sep 2014 09:50:04 +0200

[Thomas Hellström (thellstrom)]

Verified that with proposed updates in Ubuntu 12.04.5, the problem is gone.

/Thomas

[Mathew Hodson (mhodson)]

Tagging verification-done based on comment #14.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mesa-lts-trusty - 10.1.3-0ubuntu0.2~precise1

---------------
mesa-lts-trusty (10.1.3-0ubuntu0.2~precise1) precise-proposed; urgency=low

  * Copy package back to precise.

mesa (10.1.3-0ubuntu0.2) trusty; urgency=medium

  [ Timo Aaltonen ]
  * Drop fix-kwin.diff hack, as 10.1.3 has 0380ec467d78f40 which
    fixes the issue properly.

  [ Maarten Lankhorst ]
  * Add fix-svga-ioctl.patch (LP: #1365490)
 -- Maarten Lankhorst <email address hidden> Wed, 01 Oct 2014 15:14:26 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for mesa-lts-trusty has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.