mysql plugins fail on mysql 5.5/5.6

[Hans-Joachim Kliemeck]

1) The release of Ubuntu you are using, via 'lsb_release -rd' or System -> About Ubuntu
Ubuntu 14.04 LTS
2) The version of the package you are using, via 'apt-cache policy pkgname' or by checking in Software Center
munin-plugins-core:
  Installed: 2.0.19-3munin-plugins-core:
  Installed: 2.0.19-3
3) What you expected to happen / 4) What happened instead

Several of the MySQL monitors give errors like the following when used with Mysql 5.5/5.6 and multiple mysql bufferpools on trusty:

root@server:~# /etc/munin/plugins/mysql_connections
Unknown section: INDIVIDUAL BUFFER POOL INFO at /etc/munin/plugins/mysql_connections line 1098.

As far as I can tell, this issue has been addressed upsteam:

* https://github.com/munin-monitoring/munin/pull/109/

These fixes were included in the 2.1.3 release of Munin, but sadly, trusty only include 2.0.19.
https://github.com/munin-monitoring/munin/commit/8abb3faf7865af125ecc18b4feece35c59c90fd9

[Robie Basak (racb)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Next steps are:

1) Update the development release to a new enough version, or cherry-pick this fix into the development release.
2) Presumably the mysql plugin is completely broken in Trusty then, for the version of mysql shipped in Trusty? I think it would be acceptable to backport this fix to Trusty if this is the case, since there would likely be no regression risk to fix something that is completely broken.

[Hans-Joachim Kliemeck (bj7u6139zdyf-info-jjcftv6wldnz)]

Hey Robie,

thanks for the reply.

1) You are talking about a new version / cherry-pick, but who will do this? If i had to decide this, i would make a cherry-pick. Do i have the ability to cherry-pick this?
2) the mysql plugin is broken in 2 of 3 cases. As described, the error will occur if multiple bufferpools are used. This is the case for mysql 5.6 by default and for 5.5, if enabled like on high performance systems

[Jan Kellermann (jan-kellermann)]

There are some Bugfixes you need:
https://github.com/munin-monitoring/munin/pull/109/

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch-munin-mysql_.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Christian Ehrhardt  (paelzer)]

Hi,
thanks Jan for the patch!

As note to the bug - in the packaging the patch is against ./plugins/node.d/mysql_.in, so it should become a quilt patch.

I checked the latest packaged version which is 2.0.30-1 which still does not have the fix.

Although upstream that file is https://github.com/munin-monitoring/munin/blob/master/plugins/node.d/mysql_

That has the respective fix quite a long time now:
https://github.com/munin-monitoring/munin/commit/b45c07edcd3963936a7ac529620fc86f42ad6a1d

Yet not in the stable release which the packages code is based upon https://github.com/munin-monitoring/munin/blob/stable-2.0/plugins/node.d/mysql_.in

I'm not sure - should one suggest to merge this upstream into the stable release and then pick it up with the next version?
From there one can always think on backporting via an SRU to old Ubuntu releases.

[Jan Kellermann (jan-kellermann)]

Hi ChristianEhrhardt,

I patched the file mysql_ in /usr/share/munin/plugins/

This file is included in munin-plugins-core, see http://packages.ubuntu.com/xenial/all/munin-plugins-core/filelist

I dont know what the .in-file is for, I also can not find it in source-git
https://anonscm.debian.org/cgit/collab-maint/munin.git/tree/plugins/node.d

I fixed only this two bugs but tested today your linked version
https://raw.githubusercontent.com/munin-monitoring/munin/master/plugins/node.d/mysql_
(just replaced in /usr/share/munin/plugins/mysql_) and it worked without problems.

I did a short view on the diff between your link above and my patched version:
- the new version uses Storage (libstorable-perl is included in perl-package)
- some new values are given (e.g. replication)

So I think the use of the new version should be no problem. I would prefer this new version.

New symlinks are:

mysql_tables -> /usr/share/munin/plugins/mysql_
mysql_table_definitions -> /usr/share/munin/plugins/mysql_
mysql_performance -> /usr/share/munin/plugins/mysql_
mysql_mrr -> /usr/share/munin/plugins/mysql_
mysql_max_mem -> /usr/share/munin/plugins/mysql_
mysql_innodb_srv_master_thread -> /usr/share/munin/plugins/mysql_
mysql_innodb_read_views -> /usr/share/munin/plugins/mysql_
mysql_innodb_queries -> /usr/share/munin/plugins/mysql_
mysql_innodb_history_list_length -> /usr/share/munin/plugins/mysql_
mysql_handler_write -> /usr/share/munin/plugins/mysql_
mysql_handler_transaction -> /usr/share/munin/plugins/mysql_
mysql_handler_tmp -> /usr/share/munin/plugins/mysql_
mysql_handler_read -> /usr/share/munin/plugins/mysql_
mysql_files -> /usr/share/munin/plugins/mysql_
mysql_binlog_groupcommit -> /usr/share/munin/plugins/mysql_

[Leon Keijser (errtu)]

Using 16.04 here with munin-plugins-core 2.0.25-2ubuntu0.16.04.3 and experiencing the same problem. Using the mysql_ file from https://github.com/munin-monitoring/munin/blob/master/plugins/node.d/mysql_ fixes it. Can we expect an update for xenial?

[Christian Ehrhardt  (paelzer)]

Hi,
I beg your pardon for the delay, I didn't get the last update and lost track on it sicne munin really isn't my home turf.

Anyway lets make something useful now.
The latest version is 2.0.34 and still does not have the fix.

Given that we are a sync to Debian we should fix it there as well, and we need to fix it in th latest Development release anyway to qualify for an SRU [1].

So what I did was to provide a ppa [2] that you can test - it is a build with the fix applied to the latest munin version. If it works we can start fixing that one by on in the affected releases.

[1]: https://wiki.ubuntu.com/StableReleaseUpdates
[2]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3024

[Leon Keijser (errtu)]

Hi Christian,

As you can tell, I'm not very responsive either :) So don't worry.

Unfortunately I'm no longer assigned to the project that implements munin, so I'm unable to test it. I've forwarded your mail to my colleagues. Hopefully it'll be helpful to them.

Still, thank you very much for your reply and efforts. It's much appreciated!

Kind regards,

Léon

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of ChristianEhrhardt
Sent: vrijdag 3 november 2017 13:54
To: Keijser, Leon
Subject: [Bug 1364298] Re: mysql plugins fail on mysql 5.5/5.6

Hi,
I beg your pardon for the delay, I didn't get the last update and lost track on it sicne munin really isn't my home turf.

Anyway lets make something useful now.
The latest version is 2.0.34 and still does not have the fix.

Given that we are a sync to Debian we should fix it there as well, and we need to fix it in th latest Development release anyway to qualify for an SRU [1].

So what I did was to provide a ppa [2] that you can test - it is a build with the fix applied to the latest munin version. If it works we can start fixing that one by on in the affected releases.

[1]: https://wiki.ubuntu.com/StableReleaseUpdates
[2]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3024

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1364298

Title:
  mysql plugins fail on mysql 5.5/5.6

Status in munin package in Ubuntu:
  Triaged

Bug description:
  1) The release of Ubuntu you are using, via 'lsb_release -rd' or System -> About Ubuntu
  Ubuntu 14.04 LTS
  2) The version of the package you are using, via 'apt-cache policy pkgname' or by checking in Software Center
  munin-plugins-core:
    Installed: 2.0.19-3munin-plugins-core:
    Installed: 2.0.19-3
  3) What you expected to happen / 4) What happened instead

  Several of the MySQL monitors give errors like the following when used
  with Mysql 5.5/5.6 and multiple mysql bufferpools on trusty:

  root@server:~# /etc/munin/plugins/mysql_connections
  Unknown section: INDIVIDUAL BUFFER POOL INFO at /etc/munin/plugins/mysql_connections line 1098.

  As far as I can tell, this issue has been addressed upsteam:

  * https://github.com/munin-monitoring/munin/pull/109/

  These fixes were included in the 2.1.3 release of Munin, but sadly, trusty only include 2.0.19.
  https://github.com/munin-monitoring/munin/commit/8abb3faf7865af125ecc18b4feece35c59c90fd9

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/munin/+bug/1364298/+subscriptions
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.

[Andreas Hasenack (ahasenack)]

https://github.com/munin-monitoring/munin/commit/b45c07edcd3963936a7ac529620fc86f42ad6a1d is present in 2.0.37-1ubuntu1 which is in cosmic.

It's also in the bionic package (2.0.37-1ubuntu0.1). Artful and older do not have it.

[danb1974 (danb1974)]

Just to get the plugin working a one-liner for xenial is attached. Any unknown sections have to be explicitly skipped in the code.

[Athos Ribeiro (athos-ribeiro)]

As per Andreas comment (https://bugs.launchpad.net/ubuntu/+source/munin/+bug/1364298/comments/10), the fix is available since bionic, hence, I am marking this as fixreleased.

While xenial is still affected, it is now in ESM (https://ubuntu.com/security/esm), and for that, I am marking it as wontfix.