Mahara

Remove IE6 check in help icon function

Bug #1364164 reported by Yuliya Bozhko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Yuliya Bozhko
Mahara 1.10.0

Bug Description

There is no need for a check like:

$imageext = (isset($_SERVER['HTTP_USER_AGENT']) && false !== stripos($_SERVER['HTTP_USER_AGENT'], 'msie 6.0')) ? 'gif' : 'png';

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3676

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3676
Committed: http://gitorious.org/mahara/mahara/commit/4b339885dd82bc7aa63693d545e3e34ff95cf51b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b339885dd82bc7aa63693d545e3e34ff95cf51b
Author: Yuliya Bozhko <email address hidden>
Date: Tue Sep 2 10:34:20 2014 +1200

Remove IE6 check in help icon image (Bug #1364164)

Change-Id: I189ddca172cd6c364cd0f867486b434f71545998
Signed-off-by: Yuliya Bozhko <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.10.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.