[wizard] allows to "Continue" without connecting to network

Bug #1363400 reported by Michał Sawicz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Canonical Devices Products
Ubuntu UX
Fix Released
High
Olga Kemmet
ubuntu-system-settings (Ubuntu)
Invalid
High
Unassigned
ubuntu-system-settings (Ubuntu RTM)
Fix Released
High
Andrea Cimitan
unity8 (Ubuntu)
Fix Released
High
Andrea Cimitan

Bug Description

The wifi page of the wizard lets you select the network, but doesn't wait for a connection to enable the Continue button.

Until connected, the button should probably say "Skip", and if there's a connection in progress, that should be cancelled. Or we need a modal dialog introduced (like the one we have for notifications in the shell) in the wizard as well, so that you need to cancel the password entry before being able to skip.

ProblemType: Bug
DistroRelease: Ubuntu RTM 14.09
Package: ubuntu-system-settings-wizard 0.3+14.10.20140828.2~rtm-0ubuntu1
Uname: Linux 3.4.67 armv7l
ApportVersion: 2.14.6-0ubuntu2
Architecture: armhf
Date: Sat Aug 30 11:17:34 2014
InstallationDate: Installed on 2014-08-30 (0 days ago)
InstallationMedia: Ubuntu Utopic Unicorn (development branch) - armhf (20140830-030204)
SourcePackage: ubuntu-system-settings
UpgradeStatus: No upgrade log present (probably fresh install)
upstart.ubuntu-system-settings-wizard-cleanup.log:
 Ending wizard
 Resetting MIR_SOCKET to /run/mir_socket
 ()
 ubuntu-system-settings-wizard stop/waiting

Related branches

Revision history for this message
Michał Sawicz (saviq) wrote :
Revision history for this message
Michał Sawicz (saviq) wrote :

Another solution that's brewing in my head is for the greeter session to handle notifications, but that's a bigger topic.

Revision history for this message
Michał Sawicz (saviq) wrote :

Hmm, or wasn't it the plan that the network password entry would move from the bubble to the network list (when possible)?

Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
Changed in ubuntu-system-settings (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → Olga Kemmet (olga-kemmet)
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This bug report is conflating three separate issues.

First, you can tap "Continue" while a Wi-Fi password prompt is up. This is because the password prompt is implemented using a notification bubble when it should use a dialog -- which, like all dialogs, should block you from tapping anything in the screen behind it. <https://wiki.ubuntu.com/Networking#wi-fi-authenticating>

Second, whether you authenticate to a closed network, or try to join an open network, the setup doesn't wait to see whether the connection actually worked -- it just marches merrily on. The case of a closed network would be fixed by replacing the notification bubble with the authentication dialog, because that dialog should stay open so that you can make corrections if the authentication didn't work. <https://wiki.ubuntu.com/Networking#wi-fi-connecting-dialog> But that wouldn't address the case of an open network. If an open network refuses your connection attempt, for example, you should have the chance to choose a different network instead before carrying on to the next step.

Third, if you fail to connect to a network and can't fix the problem, and no other networks are available, it's not clear how you can then skip the step altogether.

Revision history for this message
Tony Espy (awe) wrote :

@Matthew

Regarding your second point, couldn't we have open networks also display a dialog that pops up when connecting too?

Regarding your third point, I'm not sure what're you're saying? If connecting to one or more networks fail the user can just tap 'Continue' to skip altogether. Neither of Michael's suggested UI changes make any difference to this as far as I can tell.

I also actually think there's a fourth problem ( or maybe this is just another aspect of your second point ), in that there's no feedback at all when connecting. Often when it succeeds, the connected network isn't even visible in the displayed network list ( see attached screenshot of wizard after successfully connecting to a secure AP ).

Are you going to break these bugs out into separate bugs?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Open networks could display a dialog during connection, but that seems like visual overkill. I suggest instead (a) changing "Continue" to "Cancel", (b) adding a spinner to the connecting network item (same as should appear in System Settings), (c) replacing it with a checkmark when connected, and (d) changing "Cancel" back to "Continue". That would solve your fourth problem too.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

This is not doable for RTM timeframe. Until we have Connectivity API with proper QML bindings supporting the whole Wifi connecting usecase, implementing this feature as mpt described is simply not feasible.

Revision history for this message
Olga Kemmet (olga-kemmet) wrote :

+1 with Matthew. Adding ota-1 if this is not feasible for rtm.

Changed in ubuntu-system-settings (Ubuntu):
assignee: Olga Kemmet (olga-kemmet) → nobody
Changed in ubuntu-ux:
status: New → Confirmed
assignee: nobody → Olga Kemmet (olga-kemmet)
importance: Undecided → Medium
tags: added: ota-1
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

tagging for ota and set to high

tags: added: rtm14
Changed in ubuntu-system-settings (Ubuntu):
importance: Medium → High
Changed in ubuntu-ux:
status: Confirmed → Fix Committed
Revision history for this message
Olga Kemmet (olga-kemmet) wrote :

I tackled this issue and wireframed it here: https://docs.google.com/a/canonical.com/document/d/1VajNkWbBH61iVixXJAmOvNGiG__GWQTMXGNOZijXWJw/edit
Please refer to page 11.

Changed in ubuntu-ux:
importance: Medium → High
Olli Ries (ories)
Changed in canonical-devices-system-image:
assignee: nobody → Canonical Devices Products (canonical-devices-products-team)
importance: Undecided → High
milestone: none → r1
status: New → Confirmed
Revision history for this message
Michał Sawicz (saviq) wrote :

As the wizard is being moved into unity8, removing the system setting task, triaging the unity8 one.

Changed in unity8 (Ubuntu):
assignee: nobody → Michael Terry (mterry)
status: New → Triaged
importance: Undecided → High
Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → Invalid
Changed in unity8 (Ubuntu RTM):
milestone: none → 14.09-ota-1
status: New → Triaged
importance: Undecided → High
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: Michael Terry (mterry) → Andrea Cimitan (cimi)
affects: unity8 (Ubuntu RTM) → ubuntu-system-settings (Ubuntu RTM)
Bill Filler (bfiller)
tags: added: settings-ww51
Michał Sawicz (saviq)
Changed in ubuntu-system-settings (Ubuntu RTM):
assignee: nobody → Andrea Cimitan (cimi)
Revision history for this message
Michał Sawicz (saviq) wrote :

We'll look at this for ww03-2015, but without syncing a big change (moving wizard into unity8), we wouldn't be able to cherry-pick into rtm.

Changed in canonical-devices-system-image:
status: Confirmed → New
Changed in ubuntu-system-settings (Ubuntu RTM):
milestone: 14.09-ota-1 → none
Revision history for this message
Ken VanDine (ken-vandine) wrote :

We couldn't cherry-pick it, but it shouldn't be a big change. The fix could be manually ported from unity8 to ubuntu-system-settings.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

moving out for more testing

Changed in canonical-devices-system-image:
milestone: ww51-2014 → ww03-2015
Changed in canonical-devices-system-image:
status: New → Confirmed
milestone: ww03-2015 → ww05-2015
Andrea Cimitan (cimi)
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Changed in ubuntu-system-settings (Ubuntu RTM):
status: Triaged → In Progress
Changed in ubuntu-system-settings (Ubuntu RTM):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20150123.1~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20150123.1~rtm-0ubuntu1) 14.09; urgency=low

  [ Andrea Cimitan ]
  * Fix continue button in wifi wizard page, adds qml-module-
    qtsysteminfo as ubuntu-system-settings-wizard dep (LP: #1363400)
 -- Ubuntu daily release <email address hidden> Fri, 23 Jan 2015 18:19:35 +0000

Changed in ubuntu-system-settings (Ubuntu RTM):
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.02+15.04.20150205-0ubuntu1

---------------
unity8 (8.02+15.04.20150205-0ubuntu1) vivid; urgency=medium

  [ Andrea Cimitan ]
  * Fix continue button in wifi wizard page, adds qml-module-
    qtsysteminfo as unity8 dep (LP: #1363400)
  * Background needs to be specified to be visible in horizontal cards
    (LP: #1411748)

  [ CI Train Bot ]
  * Resync trunk

  [ Michał Sawicz ]
  * Add workaround for gcc ICE.

  [ Albert Astals ]
  * Implement proper updateRanges for horizontal items (i.e. Carousel,
    Horizontal List)

  [ Michael Terry ]
  * Don't accept multiple "Finish" clicks during the last step of the
    wizard

  [ Daniel d'Andrada ]
  * Unify all liblightdm mocks
  * Ensure the greeter password field is not covered by the keyboard
  * Don't show() the lockscreen if it's already being shown
 -- Ubuntu daily release <email address hidden> Thu, 05 Feb 2015 10:30:13 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.