color management patch breaks PPD updating via web-interface in CUPS 1.7

[Alex Korobkin]

How to reproduce:

1. Build CUPS 1.7.x with color-management-extension.patch as it is provided by current utopic build.
Alternatively: install daily build of Utopic server.

2. Add a printer
3. Try changing printer's driver (PPD) via web interface to a different PPD.

CUPS says that printer was updated successfully, but printer won't change its PPD. You will also notice a forgotten /tmp/temp.ppd file on your filesystem.

Removing this patch fixes the problem.

[Joe Simon (jsimon383)]

Hello.

I will take a look at it.

This patch was actually submitted a year ago, prior to the recently updated color management infrastructure via cups-filters.

Joe Simon

[Joe Simon (jsimon383)]

I can confirm - replacing a PPD for a newly added printer has no effect after the patch, or using the daily build. It also includes /tmp/temp.ppd.

Please try using the attached patch and see if the side-effect is still there.

You may have to restart your system/cups server after building and installing it.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "cups-1.7.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Till Kamppeter (till-kamppeter)]

Joseph, thank you for the updated patch. I have committed it to the Debian GIT repository of CUPS now.

[Alex Korobkin (korobkin)]

Is this patch supposed to replace current color-management-extension.patch, or is it an addition to it?

I cannot build CUPS if I replace the patch with the provided one, tests fail. Was able to build it fine with old version of the patch and without the patch.

Running command tests...
Waiting for jobs to complete...3...
Performing 5.1-lpadmin.sh: PASS
Waiting for jobs to complete...
Performing 5.2-lpc.sh: PASS
Waiting for jobs to complete...
Performing 5.3-lpq.sh: FAIL
Waiting for jobs to complete...
Performing 5.4-lpstat.sh: PASS
Waiting for jobs to complete...
Performing 5.5-lp.sh: FAIL
Waiting for jobs to complete...
Performing 5.6-lpr.sh: FAIL
Waiting for jobs to complete...
Performing 5.7-lprm.sh: FAIL
Waiting for jobs to complete...1...
Performing 5.8-cancel.sh: FAIL
Waiting for jobs to complete...2...
Performing 5.9-lpinfo.sh: PASS
Test Summary

FAIL: 15 job control files were not purged.
PASS: Printer 'Test1' correctly produced 15 page(s).
FAIL: Printer 'Test2' produced 1 page(s), expected 23.
FAIL: Printer 'Test3' produced 0 page(s), expected 2.
FAIL: 59 requests logged, expected 163.
PASS: CUPS-Get-Default not logged.

[Joe Simon (jsimon383)]

I have attached a second patch that should solve the command testing issues in 1.7.x.

These patches are a replacement for the "color-management-extension.patch", which should conform to the new color management in cups-filters.

[Till Kamppeter (till-kamppeter)]

Joseph thanks for the updated patch. I have now committed this version to Debian's GIT repo of CUPS.

[Alex Korobkin (korobkin)]

Your new patch cannot be applied as it is, because it has garbage lines like "Binary files cups-1.7/.git/index and cups-1.7new/.git/index differ"
However, it applies fine if these lines are removed, and PPD seems to update fine via web interface when the patch is applied.

[Till Kamppeter (till-kamppeter)]

Alex, this is all already taken care of. I have applied the patch (after removing the broken parts) and committed it to the Debian repository. So the next CUPS package in Utopic will contain the patch correctly applied.

Alex, thank you very much for testing the patch, so that we know that all is working correctly now.

Joseph, when generating patches, take care that only changes in the upstream files get recorded, not in any hidden directory from the version control system, quilt, ... and not in the debian/ directory.

[Joe Simon (jsimon383)]

Alex: Thank you for checking the patches. Glad to know that it works now.

Till: Understood. I will keep this in mind for any future patches to CUPS.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cups - 1.7.5-2

---------------
cups (1.7.5-2) unstable; urgency=medium

  [ Helge Kreutzmann ]
  * Update German man page (1537t)

  [ Till Kamppeter ]
  * Updated color management extension patch to the newest version from Joseph
    Simon, especially to fix PPD updates via the web interface (LP: #1362321).

  [ Didier Raboud ]
  * Replace the RedHat patch restoring the access to cupsd.conf and logfiles
    with upstream's

 -- Didier Raboud <email address hidden> Wed, 17 Sep 2014 13:37:01 +0200