ovsdb_monitor.SimpleInterfaceMonitor throws eventlet.timeout.Timeout(5)

Bug #1358206 reported by Miguel Angel Ajo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
John Schwarz

Bug Description

This is found during functional testing, when .start() is called with
block=True during sightly high load.

This suggest the default timeout needs to be rised to make this module
work in all situations.

https://review.openstack.org/#/c/112798/14/neutron/agent/linux/ovsdb_monitor.py (I will extract patch from here)

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114927

Changed in neutron:
assignee: nobody → Miguel Angel Ajo (mangelajo)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/114927
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=44eff5daad81966f6530d84ca3683b2f9c58debf
Submitter: Jenkins
Branch: master

commit 44eff5daad81966f6530d84ca3683b2f9c58debf
Author: Miguel Angel Ajo <email address hidden>
Date: Mon Aug 18 12:32:26 2014 +0200

    Increase ovsdb_monitor.SimpleInterfaceMonitor start timeout

    The current timeout fails during functional testing with
    slightly higher load. Increasing it will lower the timeout
    chances during high load conditions. Changed from 5 seconds
    to respawn_interval/2. DEFAULT_OVSDBMON_RESPAWN = 30 , so
    the default timeout will be 15 seconds.

    Change-Id: I6a9e2977b275e96dcf01c4df90a33169c42287d6
    Closes-Bug: #1358206

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/119001

Maru Newby (maru)
Changed in neutron:
assignee: Miguel Angel Ajo (mangelajo) → John Schwarz (jschwarz)
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/119034

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/119001
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fdf0fa8b43537bbd5ab6e1a2e55f694b77209a00
Submitter: Jenkins
Branch: master

commit fdf0fa8b43537bbd5ab6e1a2e55f694b77209a00
Author: John Schwarz <email address hidden>
Date: Thu Sep 4 11:34:29 2014 +0300

    Fix leftover Timeout effecting most eventlet calls

    When registering a new eventlet.timeout.Timeout object, eventlet
    automatically starts a timer for most (if not all) future eventlet
    calls. Normally, eventlet codes do not hold a timeout unless such a
    timeout is used or a specific timeout length is specified through
    the API, but once a Timeout object is initialized, it is left there
    unless canceled.

    This change fixes an un-canceled Timeout which causes some
    functional tests to fail, reintroduces a fix for bug #1358206,
    which was written prior to discovering the uncanceled timeout, and
    increases the timeout of a test that depended on this timeout.

    Closes-bug: #1358206
    Related-bug: #1364171
    Change-Id: I1bfc5af6917c525894eecd8b477d787763edbd02

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/119034
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=85aa417d77bd3402690e26f105465f0338897cfd
Submitter: Jenkins
Branch: master

commit 85aa417d77bd3402690e26f105465f0338897cfd
Author: John Schwarz <email address hidden>
Date: Thu Sep 4 14:11:26 2014 +0300

    Revert "Skip functional l3 agent test"

    This reverts commit 0918ce91e5af5100ee3a4fcd6861741c4f00ac41. The
    specified commit skipped a test which caused non-deterministic gate
    failures, but the actual reason for the failures was found and fixed
    so the skip is no longer needed.

    Related-bug: #1358206
    Related-bug: #1364171
    Change-Id: I9b0d9ad9ad8b62ee92877fc0a6db0323604433ac

John Schwarz (jschwarz)
Changed in neutron:
status: Fix Committed → Fix Released
Changed in neutron:
status: Fix Released → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.