volume type allows name with only white spaces

[Gloria Gu]

When create volume type, it allows name field with only white spaces.

How to reproduce:

go to admin -> volume to create a volume type with only white spaces as a name, the volume type shows up in the volume table an empty name.

Expect:

form should not allow empty name when create volume type

[Gary W. Smith (gary-w-smith)]

Looks similar to https://bugs.launchpad.net/horizon/+bug/1291414. This seems to be a common problem in dialogs that prompt for a name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115064

[Gloria Gu (gloria-gu)]

there is a similar bug in cinder...https://bugs.launchpad.net/cinder/+bug/1206396

[Gloria Gu (gloria-gu)]

volume type 's name is required field in cinder, while volume name and snapshot name are display-name in cinder. So I will separate the bug to reflect that fact.

[Gloria Gu (gloria-gu)]

cinder defect triaged

https://bugs.launchpad.net/cinder/+bug/1370273

[Gloria Gu (gloria-gu)]

Well , from UI world, if empty spaces cause issues, it would be better prevent it which is a common practice. However openstack folks don't agree. It is a trivial issue so it is not worth to push it.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Gloria Gu (<email address hidden>) on branch: master
Review: https://review.openstack.org/115064
Reason: In the UI world, if it would be better prevent user entering empty spaces if they cause issues. It is a common practice. However openstack folks don't agree. It is a trivial issue so it is not worth to push it.

[Gary W. Smith (gary-w-smith)]

Changing status per comment #7

[Zhenguo Niu (niu-zglinux)]

As there's a restrict on cinder side now: https://github.com/openstack/cinder/blob/master/cinder/api/contrib/types_manage.py#L65

I will takeover this and resubmit a new patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/181027

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/181027
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0c70bf420490130117455f4da9e0b4da0678273b
Submitter: Jenkins
Branch: master

commit 0c70bf420490130117455f4da9e0b4da0678273b
Author: Zhenguo Niu <email address hidden>
Date: Thu May 7 22:44:53 2015 +0800

    Add empty name check to volume types

    As cinder doesn't allow creating volume types with empty name, so
    add a check for that on horizon.

    Change-Id: Ie795e54952e92dd9a198306306ffead0cc84ca99
    Closes-Bug: #1357586