image create/edit image wizard allows name with white spaces only

[Benny Kopilov]

Description of problem:
When we create /modify image name , the user interface does not allow to set empty string
When user set single white space , the image name changed to image_id .

when name contains only what spaces it should be denied as empty string .

Version-Release number of selected component (if applicable):

How reproducible:
always

Steps to Reproduce:
create image name from dashboard .
change the name with edit option , set spaces only .
save and name changed to image_id .

Actual results:
the image name taken from image_id in database.

Expected results:
white spaces name should be rejected by ui .

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80323

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Manuel Ollé (<email address hidden>) on branch: master
Review: https://review.openstack.org/80323
Reason: This is wrong, overloading _clean_fields if a very bad idea, it depends on django internal implementation.

From an OO design point of view, extending CharField is the correct way to fix this issue.

Patch 6 is the correct way to fix this.

Thanks all of you for your time

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115064

[OpenStack Infra (hudson-openstack)]

Change abandoned by Gloria Gu (<email address hidden>) on branch: master
Review: https://review.openstack.org/115064
Reason: In the UI world, if it would be better prevent user entering empty spaces if they cause issues. It is a common practice. However openstack folks don't agree. It is a trivial issue so it is not worth to push it.