[Browser] restoring browser shows blank tab previews
Bug #1357464 reported by
Bill Filler
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Medium
|
Unassigned | ||
webbrowser-app |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
after closing the browser and reopening, the open tabs are now restored which is great. However when viewing the tabs page, all of the previews are blank which makes for a pretty ugly looking page.
Can we persist these preview images, same as we're doing for the favicon images so that we can restore them when the app starts?
If not, we should minimally show something in the tab preview like "Click to open" or some other graphic
Related branches
lp:~osomon/webbrowser-app/lazy-webviews
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Michael Sheldon (community): Approve
-
Diff: 1200 lines (+314/-203)12 files modifiedpo/webbrowser-app.pot (+17/-13)
src/app/webbrowser/Browser.qml (+98/-41)
src/app/webbrowser/TabPreview.qml (+33/-9)
src/app/webbrowser/TabsView.qml (+11/-7)
src/app/webbrowser/tabs-model.cpp (+36/-36)
src/app/webbrowser/tabs-model.h (+7/-7)
src/app/webbrowser/webbrowser-app.qml (+2/-1)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+6/-0)
tests/autopilot/webbrowser_app/tests/test_session_save_restore.py (+1/-0)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+6/-1)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+94/-88)
lp:~osomon/webbrowser-app/rtm-trunk-sync-20140826
- Ubuntu Phablet Team: Pending requested
-
Diff: 1480 lines (+432/-252)17 files modifiedpo/webbrowser-app.pot (+17/-13)
src/app/WebViewImpl.qml (+2/-0)
src/app/webbrowser/BookmarksModel.qml (+24/-0)
src/app/webbrowser/Browser.qml (+156/-84)
src/app/webbrowser/HistoryModel.qml (+24/-0)
src/app/webbrowser/TabPreview.qml (+33/-9)
src/app/webbrowser/TabsView.qml (+11/-7)
src/app/webbrowser/tabs-model.cpp (+36/-36)
src/app/webbrowser/tabs-model.h (+7/-7)
src/app/webbrowser/webbrowser-app.qml (+2/-1)
src/app/webcontainer/WebApp.qml (+9/-6)
src/app/webcontainer/WebappContainerWebview.qml (+1/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+6/-0)
tests/autopilot/webbrowser_app/tests/test_session_save_restore.py (+1/-0)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+6/-1)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+94/-88)
Changed in webbrowser-app: | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in webbrowser-app: | |
importance: | Undecided → High |
Changed in webbrowser-app (Ubuntu): | |
importance: | Undecided → High |
tags: | added: rtm14 |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
summary: |
- restoring browser shows blank tab previews + [Browser] restoring browser shows blank tab previews |
Changed in ubuntu-ux: | |
importance: | Undecided → Medium |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Unfortunately this is not a simple problem. We’re currently using a ShaderEffectSource item to capture the contents of a webview and display a paused thumbnail. This works well while the webview is live and has been shown at least once. But when the app is restored after being killed, only the current webview has been shown, all the other webviews are hidden, so there is no capture available.
QML doesn’t expose any built-in way of persisting the contents of an item as an image on disk, which is what would be needed to restore tab previews.
Also note that we’re currently not persisting favicons on disk either, they are being re-downloaded everytime, this is bug #1340585.