Only display dual SIM settings when multiple SIMs are present, not modems
Bug #1357393 reported by
Ken VanDine
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-system-settings (Ubuntu) |
Fix Released
|
Critical
|
Jonas G. Drange | ||
Bug Description
Right now we display settings for multiple SIMs based on the presence of modems, not SIMs themselves. This isn't useful, we should display settings only for the SIMs that are present.
Related branches
lp:~jonas-drange/ubuntu-system-settings/1357393-fix
- Ken VanDine: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1330 lines (+695/-218)16 files modifiedplugins/cellular/CMakeLists.txt (+1/-0)
plugins/cellular/Components/CMakeLists.txt (+4/-1)
plugins/cellular/Components/CellularMultiSim.qml (+16/-18)
plugins/cellular/Components/CellularSingleSim.qml (+13/-14)
plugins/cellular/Components/DefaultSim.qml (+3/-4)
plugins/cellular/Components/MultiSim.qml (+120/-0)
plugins/cellular/Components/NoSim.qml (+51/-0)
plugins/cellular/Components/Sim.qml (+2/-0)
plugins/cellular/Components/SimEditor.qml (+8/-8)
plugins/cellular/Components/SingleSim.qml (+76/-0)
plugins/cellular/PageChooseCarriers.qml (+9/-10)
plugins/cellular/PageComponent.qml (+42/-159)
plugins/cellular/sims.js (+34/-0)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+5/-3)
tests/autopilot/ubuntu_system_settings/tests/ofono.py (+215/-0)
tests/autopilot/ubuntu_system_settings/tests/test_cellular.py (+96/-1)
lp:~ken-vandine/ubuntu-system-settings/rtm-14.09-20140822
- Brendan Donegan (community): Needs Information
- Ubuntu Touch System Settings: Pending requested
-
Diff: 7008 lines (+2952/-1127)104 files modifieddebian/changelog (+74/-0)
debian/control (+1/-1)
plugins/about/storageabout.cpp (+11/-7)
plugins/battery/PageComponent.qml (+1/-2)
plugins/battery/SleepValues.qml (+19/-9)
plugins/battery/battery.cpp (+4/-6)
plugins/bluetooth/PageComponent.qml (+174/-142)
plugins/bluetooth/agent.h (+1/-1)
plugins/bluetooth/bluetooth.cpp (+1/-3)
plugins/bluetooth/bluetooth.h (+5/-5)
plugins/bluetooth/device.cpp (+1/-0)
plugins/cellular/CMakeLists.txt (+1/-0)
plugins/cellular/Components/CMakeLists.txt (+4/-1)
plugins/cellular/Components/CellularMultiSim.qml (+18/-20)
plugins/cellular/Components/CellularSingleSim.qml (+13/-14)
plugins/cellular/Components/DefaultSim.qml (+3/-4)
plugins/cellular/Components/MultiSim.qml (+120/-0)
plugins/cellular/Components/NoSim.qml (+51/-0)
plugins/cellular/Components/Sim.qml (+2/-0)
plugins/cellular/Components/SimEditor.qml (+8/-8)
plugins/cellular/Components/SingleSim.qml (+76/-0)
plugins/cellular/PageChooseCarriers.qml (+9/-10)
plugins/cellular/PageComponent.qml (+42/-159)
plugins/cellular/sims.js (+34/-0)
plugins/notifications/notification_item.cpp (+2/-1)
plugins/phone/CMakeLists.txt (+5/-0)
plugins/phone/CallForwarding.qml (+17/-13)
plugins/phone/CallWaiting.qml (+14/-3)
plugins/phone/MultiSim.qml (+135/-0)
plugins/phone/NoSims.qml (+46/-0)
plugins/phone/Ofono.qml (+50/-0)
plugins/phone/PageComponent.qml (+64/-39)
plugins/phone/Services.qml (+4/-1)
plugins/phone/SingleSim.qml (+57/-0)
plugins/phone/sims.js (+34/-0)
plugins/security-privacy/LockSecurity.qml (+3/-2)
plugins/security-privacy/PageComponent.qml (+57/-37)
plugins/security-privacy/PhoneLocking.qml (+27/-4)
plugins/security-privacy/trust-store-model.cpp (+1/-1)
plugins/system-update/PageComponent.qml (+320/-329)
plugins/system-update/update_manager.cpp (+2/-1)
plugins/time-date/timezonelocationmodel.cpp (+2/-2)
po/am.po (+1/-1)
po/en_AU.po (+22/-21)
po/en_GB.po (+23/-21)
po/es.po (+21/-21)
po/fi.po (+43/-41)
po/fr.po (+8/-5)
po/gl.po (+7/-7)
po/he.po (+28/-28)
po/hu.po (+21/-20)
po/pt.po (+16/-16)
po/ro.po (+18/-16)
po/ru.po (+21/-19)
po/uk.po (+22/-21)
src/i18n.cpp (+1/-1)
src/plugin-manager.cpp (+1/-1)
src/plugin.cpp (+4/-4)
tests/autopilot/ubuntu_system_settings/__init__.py (+150/-0)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+60/-6)
tests/autopilot/ubuntu_system_settings/tests/ofono.py (+215/-0)
tests/autopilot/ubuntu_system_settings/tests/test_cellular.py (+96/-1)
tests/autopilot/ubuntu_system_settings/tests/test_phone.py (+111/-0)
tests/autopilot/ubuntu_system_settings/tests/test_security.py (+173/-0)
tests/autopilot/ubuntu_system_settings/tests/test_system_updates.py (+0/-4)
tests/plugins/bluetooth/tst_bluetooth.cpp (+1/-1)
tests/plugins/bluetooth/tst_devicemodel.cpp (+1/-1)
tests/plugins/system-update/tst_update.cpp (+1/-1)
tests/plugins/system-update/tst_updatemanager.cpp (+1/-1)
tests/test-plugin2.cpp (+2/-2)
tests/tst_arguments.cpp (+1/-1)
tests/tst_plugins.cpp (+1/-1)
wizard/CMakeLists.txt (+2/-0)
wizard/main.cpp (+33/-4)
wizard/qml/Components/CheckableSetting.qml (+80/-0)
wizard/qml/Components/Page.qml (+4/-1)
wizard/qml/Pages/10-welcome.qml (+1/-0)
wizard/qml/Pages/30-location.qml (+72/-0)
wizard/qml/Pages/40-reporting.qml (+2/-4)
wizard/qml/Pages/80-finished.qml (+2/-4)
wizard/qml/Pages/data/HEREposconsent_da-DK.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_de-DE.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_en-GB.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_en-US.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_es-ES.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_es-MX.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_fr-FR.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_it-IT.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_ja-JP.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_ko-KR.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_nl-NL.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_pl-PL.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_pt-BR.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_pt-PT.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_ru-RU.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_sv-SE.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_zh-CN.html (+1/-0)
wizard/qml/Pages/data/HEREposconsent_zh-TW.html (+1/-0)
wizard/qml/Pages/no-sim.qml (+2/-4)
wizard/qml/Pages/terms.qml (+119/-0)
wizard/qml/main.qml (+4/-1)
wizard/ubuntu-system-settings-wizard-cleanup.conf (+0/-17)
wizard/ubuntu-system-settings-wizard-set-lang.conf (+30/-0)
wizard/ubuntu-system-settings-wizard.conf (+0/-5)
| Changed in ubuntu-system-settings (Ubuntu): | |
| assignee: | nobody → Jonas G. Drange (jonas-drange) |
| importance: | Undecided → Critical |
| status: | New → Confirmed |
| tags: | added: rtm14 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | Confirmed → Opinion |
| status: | Opinion → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ Charles Kerr ]
* In the welcome wizard, refresh the text in the 'no sim card' and
'all done' pages to match the latest from design.
[ Michael Terry ]
* Add a location page and a terms and conditions page for the HERE
service.
[ Ken VanDine ]
* Settings for idle/lock timeout (LP: #1230345)
* Added flickable to fix scrolling (LP: #1354161)
[ Jussi Pakkanen ]
* Fix a bunch of compiler warnings.
[ jonas-drange ]
* [cellular] displays cellular UIs based on how many SIMs are present.
(LP: #1357393)
-- Ubuntu daily release <email address hidden> Fri, 22 Aug 2014 18:57:00 +0000