One time of 128, session is opened incorrectly

[Dmitry Shachnev]

== Impact ==
Sometimes (one time of 128), the binary representation of common secret is 127 bytes long instead of 128, which makes the session invalid, and encrypting/decrypting produces wrong results (or crashes).

This will lead to end-user tools (like most tools in ubuntu-dev-tools) to be working incorrectly.

== Test case ==
This can be easily reproduced by running upstream test suite (for example via autopkgtest) many times.

== Development fix ==
Fixed in 2.1.1, which is now in utopic

https://github.com/mitya57/secretstorage/commit/d55efce2c04b053c

== Regression Potential ==
Two-lines fix, does not cause any regressions

[Brian Murray (brian-murray)]

Hello Dmitry, or anyone else affected,

Accepted python-secretstorage into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/python-secretstorage/2.0.0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Dmitry Shachnev (mitya57)]

The testsuite succeeded > 50 times in a row (before this version it failed before 20th try).

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-secretstorage - 2.0.0-1ubuntu1.1

---------------
python-secretstorage (2.0.0-1ubuntu1.1) trusty; urgency=medium

  * Fix name of the previous patch.
  * debian/patches/fix_session_creation.diff: make sure common secret
    is exactly 128 bytes long (LP: #1352997).
 -- Dmitry Shachnev <email address hidden> Tue, 05 Aug 2014 21:05:29 +0400

[Scott Kitterman (kitterman)]

The verification of the Stable Release Update for python-secretstorage has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.