upgrade complains of duplicate cron row

Bug #1350254 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.7
Fix Released
High
Robert Lyon
1.8
Fix Released
High
Robert Lyon
1.9
Fix Released
High
Robert Lyon

Bug Description

Problem with ensure_record_exists is checking the nextrun column when it shouldn't

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3537

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3538

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3539

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.7_STABLE" branch: https://reviews.mahara.org/3540

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3537
Committed: http://gitorious.org/mahara/mahara/commit/ff381c44344ff396dedc5474f0e9e320922c049e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ff381c44344ff396dedc5474f0e9e320922c049e
Author: Robert Lyon <email address hidden>
Date: Wed Jul 30 21:17:17 2014 +1200

Fixing upgrade script (Bug #1350254)

Problem with ensure_record_exists checking nextrun column will break
things when adding new cron line to cron table.

This is due the the nextrun not being null after it has run.

Change-Id: I1f674cbc842a3e061224bf996cc0267b09018f55
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3538
Committed: http://gitorious.org/mahara/mahara/commit/d2e985a0efd066617efb902eaba56226335150bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit d2e985a0efd066617efb902eaba56226335150bc
Author: Robert Lyon <email address hidden>
Date: Wed Jul 30 21:17:17 2014 +1200

Fixing upgrade script (Bug #1350254)

Problem with ensure_record_exists checking nextrun column will break
things when adding new cron line to cron table.

This is due the the nextrun not being null after it has run.

Change-Id: I1f674cbc842a3e061224bf996cc0267b09018f55
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3540
Committed: http://gitorious.org/mahara/mahara/commit/9fdc16ebe0363403dc75616db4fefe453cd284e2
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.7_STABLE

commit 9fdc16ebe0363403dc75616db4fefe453cd284e2
Author: Robert Lyon <email address hidden>
Date: Wed Jul 30 21:17:17 2014 +1200

Fixing upgrade script (Bug #1350254)

Problem with ensure_record_exists checking nextrun column will break
things when adding new cron line to cron table.

This is due the the nextrun not being null after it has run.

Change-Id: I1f674cbc842a3e061224bf996cc0267b09018f55
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3539
Committed: http://gitorious.org/mahara/mahara/commit/40c76c1dc245c4e72c68c36ea7b374bd1e18f748
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit 40c76c1dc245c4e72c68c36ea7b374bd1e18f748
Author: Robert Lyon <email address hidden>
Date: Wed Jul 30 21:17:17 2014 +1200

Fixing upgrade script (Bug #1350254)

Problem with ensure_record_exists checking nextrun column will break
things when adding new cron line to cron table.

This is due the the nextrun not being null after it has run.

Change-Id: I1f674cbc842a3e061224bf996cc0267b09018f55
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.