whoopsie-upload-all uses an incorrect assumption regarding what to upload

[Brian Murray]

There is a comment in whoopsie-upload-all which states:

" errors.ubuntu.com does not collect any hook data anyway, so we do not need
    to bother collecting it."

This is incorrect, while errors.ubuntu.com does not use any package hook data at least some of the Ubuntu general hook and the generic hook would be useful (their data would appear on a specific OOPS's page). whoopsie currently uploads the following fields which are not collected by whoopsie-upload-all:

ApportVersion
NonfreeKernelModules

Additionally, while whoopsie does not currently upload SystemImageInfo (which would come from add_release_info in the Ubuntu general hook) it would be very useful to have but whoopsie-upload-all does not collect it.

[Martin Pitt (pitti)]

Fixed in trunk r2825.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.14.5-0ubuntu1

---------------
apport (2.14.5-0ubuntu1) utopic; urgency=medium

  * New upstream bug fix release. Changes since last snapshot:
    - apt/dpkg get_file_package(): If checking for uninstalled packages, don't
      use package information from the host system, but always look it up in
      the correct indexes. Otherwise this returns wrong results when files
      move to a different package between releases. Thanks Brian Murray!
      (LP: #1336062)
    - apt/dpkg install_packages(): Disable fetching apt translation indexes,
      to save some bandwidth.
    - whoopsie-upload-all: Ignore crash reports with incomplete core dumps
      instead of crashing on them. Thanks Brian Murray. (LP: #1329520)
    - etc/default/apport: Fix comment to use "service" instead of calling the
      init.d script directly.
    - whoopsie-upload-all: Collect hooks information to gather ApportVersion,
      NonfreeKernelModules, and SystemImageInfo. Do this before collecting
      package data to minimize hook run time. (LP: #1349579)
    - Adjust report.test_get_logind_session test to work with systemd >= 205.
    - Fix report.test_check_interpreted_twistd test to skip instead of fail if
      twisted is not installed.

  * Drop automatix.py general hook. Automatix is long gone.
  * etc/apport/blacklist.d/apport: Drop long obsolete npviewer/npplayer
    entries.
  * Drop unnecessary python-gi build dependency.
  * Drop python-twisted-core build dependency. It's just used for one test,
    and will still run in autopkgtest. (Avoids current twisted
    uninstallability in main)
 -- Martin Pitt <email address hidden> Tue, 29 Jul 2014 12:26:23 +0200

[Brian Murray (brian-murray)]

Thanks for fixing this quickly.