Profile completion: make a friend bug

Bug #1348428 reported by shanen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
1.9
Fix Released
Medium
Robert Lyon

Bug Description

Mahara 1.9
Hi Everyone,
Just sitting with a colleague testing the profile completion feature.

Background - The Make a Friend condition: he sent me a friend request which I didn't respond to.
Instead I sent him a friend request which he accepted.
So he now has a friend. However his profile completion block is still asking him to make a friend.

As a face book user he said that facebook profile completion accepts you have made a friend regardless of who initiates the friend request.

Perhaps Mahara should consider that you have made a friend by counting how many friends you have. EG more than one means you have made a friend regardless of how? Also this might work better for people who already have friends and the system can tick this off straight away.

Thanks,
Shane.

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 1.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3511

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3511
Committed: http://gitorious.org/mahara/mahara/commit/cf2f76655ed1b7f820b56d70129ecd56b143caa8
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit cf2f76655ed1b7f820b56d70129ecd56b143caa8
Author: Robert Lyon <email address hidden>
Date: Fri Jul 25 16:11:08 2014 +1200

Count both inititing and accepting friends (Bug 1348428)

When counting 'make friends' towards progress bar

Change-Id: I50574ac5339b07d89e194f915f6feeded91e28fd
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3855

Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3855
Committed: http://gitorious.org/mahara/mahara/commit/27b126eee3603fa43fecc1aa3b5b7ae4a3681f8c
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 27b126eee3603fa43fecc1aa3b5b7ae4a3681f8c
Author: Robert Lyon <email address hidden>
Date: Fri Jul 25 16:11:08 2014 +1200

Count both inititing and accepting friends (Bug 1348428)

When counting 'make friends' towards progress bar

Change-Id: I50574ac5339b07d89e194f915f6feeded91e28fd
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.