Minor inconsistency in d/tests/control format

Bug #1347958 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autopkgtest (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

It's only a minor inconsistency, but I find it a little strange that items in the Tests: and Restrictions: headers are space separated, but items in the Depends: are comma separated.

I was faced with this when I accidentally comma separated the Restrictions field for one of my tests, e.g.:

Restrictions: isolation-container, allow-stderr

and adt-run did not run the test. It also didn't tell me that it was skipping the test or why it was skipping it; it was just silently skipping it. Once I removed the comma, the test was run.

Related branches

Revision history for this message
Martin Pitt (pitti) wrote :

Indeed, this annoyed me as well, yay for keeping backwards compatibility and historical errors. But I suppose Tests/Restrictions/etc. should just accept either (space or comma or both), as in all those fields we only need to recognize single words.

Changed in autopkgtest (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in autopkgtest (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package autopkgtest - 3.3.1

---------------
autopkgtest (3.3.1) unstable; urgency=medium

  * Accept comma separators in Tests:, Restrictions:, and Features: fields;
    this is consistent with Depends: and avoids skipping tests. (LP: #1347958)
  * Generalize implementation of getting an interactive shell in testbeds.
    Most runners now don't need to provide a hook_shell() any more.
  * Export install environment to interactive testbed shells, so that
    unpacked test depends in the temp dir are accessible. (LP: #1339103)
  * lxc: Don't fail on a nonexisting /etc/environment or /etc/default/locale.
    (LP: #1348749)
  * adb ssh script: Add --apt-update option to run "apt-get update" (with
    temporarily switching to r/w), to run tests on older development images.
    (LP: #1342838)
  * Drop the very short and unnecessary install timeouts from the NullRunner
    tests.

 -- Martin Pitt <email address hidden> Tue, 29 Jul 2014 13:45:36 +0200

Changed in autopkgtest (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.