Tracks are not numerically sorted when sorting by album [$5]

[Sam Hewitt]

When sorting by album the album's tracks are out-of order –they're not sorted numerically. This is also a problem when sorting by track as a whole.

Affects Noise 0.3.0+r1641+pkg78~ubuntu0.3.1

[Shawn McTear (syst3mfailur3)]

Some songs are also incorrectly placed between songs from another album.

[Isaac Parris (dexcasul)]

Nevermind that last bit. I see it now.

[Isaac Parris (dexcasul)]

On my Luna installation it seems to work just fine. Is this an issue with the newer Freya verison?

Changed back to New for now. I'll have to check it out on Freya first.

[Shawn McTear (syst3mfailur3)]

Porbably should have linked the Bountysource link: https://www.bountysource.com/issues/3301604-tracks-are-not-numerically-sorted-when-sorting-by-album-5

[Cameron Norman (cameronnemo)]

Can confirm, I am running noise, version 0.3.0+r1641+pkg78~ubuntu0.3.1 on debian Sid in the GNOME environment. It looks like what is happening is that every pair of songs is getting flopped. I will try to explain in a video or something...

[Piotr Marcinkowski (md5sum)]

Hallo all,

I think i have found root cause. The problem is calling `foreach` on HashTable. It seems that `foreach` does not iterate througth HashTable properly. I checked it by pasting the followed code into `reorder_request` member function (right after quicksort) in FastView.vala file.

Code:
        stderr.printf("\n\nresort\n");
        table.foreach ((key, val) => {
            stderr.printf("%s\n", ((Media)val).get_display_title ());
        });

        stderr.printf("\n\nresort2\n");
        for(int i = 0; i < table.size(); ++i) {
            stderr.printf("%s\n", ((Media)table.get (i)).get_display_title ());
        }

Please find the result attached.
Calling foreach on HashTables was introduced in rev 1601.

[Li Chong (l-chong-v)]

It's solved. Thanks!

[zaporcezar (zaporcezar)]

Sorting songs take way to much time... and does not work correctly

[Gero.Bare (gero-bare)]

@zaporcezar

Please be more specific.
It is a current build? It's a distribution package?

What doesn't work properly? Track numbers, albums, artist?

About the speed. The last patch it should not affect the speed. The speed issue was present after an update? Can you list the version? Also the Number of songs you are dealing with.

In the case of speed you might refer to this bug also https://bugs.launchpad.net/noise/+bug/1350450

[Jonathan Lumb (jonolumb)]

I am running noise_0.3.0+r1698+pkg85~ubuntu0.3.1_i386.deb and this still isn't working for me. Tracks still don't display in the right order.

Any ideas?

[Gero.Bare (gero-bare)]

Sorry guys I missed something.

I never considered the condition you are filtering your library with a search, the logic was left untouched and that trigger the problem. I was to blame here.

Now it should handle both conditions, sort the whole library and sort the results of a filtered library.

Sorry.

@Cody Garver
Please update this again, sorry for the trouble.

[Jonathan Lumb (jonolumb)]

No problem - I was indeed filtering the library with a search. Once this is
committed and I can see it works, I'll make sure the bounty is paid out.
Thanks for your hard efforts to improve such a brilliant music app!

On 13 October 2014 10:33, Gero.bare <email address hidden> wrote:

> Sorry guys I missed something.
>
> I never considered the condition you are filtering your library with a
> search, the logic was left untouched and that trigger the problem. I was
> to blame here.
>
> Now it should handle both conditions, sort the whole library and sort
> the results of a filtered library.
>
> Sorry.
>
> @Cody Garver
> Please update this again, sorry for the trouble.
>
> ** Changed in: noise
> Status: Fix Committed => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1346678
>
> Title:
> Tracks are not numerically sorted when sorting by album [$5]
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/noise/+bug/1346678/+subscriptions
>

--
Jonathan Lumb
Translator & Conference Interpreter
Shanghai, 上海
[phone] | <email address hidden>

[Gero.Bare (gero-bare)]

No, thanks to you. Your input was very helpful, it was thanks to you that I was able to identify the last part of the puzzle. The previous report left me with more questions than answers.

Also it was very helpful the fact that your input was while I had the things fresh, otherwise I probably couldn't fix this. I'm not very familiar with the code base yet. I just started some days ago to read the code.