crash when the screen dimensions are not correctly defined

[Fabien Tassin]

crash in gnome-appearance-properties from gnome-control-center 2.19.90-0ubuntu1, on i386.

Trace is :

Program received signal SIGFPE, Arithmetic exception.
[Switching to Thread -1227577680 (LWP 21785)]
0x0805a649 in cb_show_details (button=0x809c208, data=0x8263890) at
appearance-font.c:828
828 appearance-font.c: No such file or directory.
        in appearance-font.c
(gdb) bt
#0 0x0805a649 in cb_show_details (button=0x809c208, data=0x8263890) at
appearance-font.c:828
#1 0xb76e6c09 in g_cclosure_marshal_VOID__VOID () from
/usr/lib/libgobject-2.0.so.0
#2 0xb76d9772 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#3 0xb76ea2fd in ?? () from /usr/lib/libgobject-2.0.so.0
#4 0x0846dc48 in ?? ()
#5 0x00000000 in ?? ()

appearance-font.c line 828 is :

    /* pick a sensible maximum dpi */
    dpi = floor ((gdk_screen_width () / gdk_screen_width_mm () +
                 gdk_screen_height () / gdk_screen_height_mm ()) * 25.4 / 2. + .5);

so either gdk_screen_width_mm () or gdk_screen_height_mm () or both returned zero.

Indeed, it looks like everything related to dpi is impacted (like firefox using desktop fonts)

100% reproducible, even after a reboot.

[QuentinHartman (qhartman)]

I have been working in gnome-appearance-properties today trying to confirm another bug, but was unable to reproduce the crash. Can you say specifically what you did just prior to the crash? Using the same version of gnome-control-center on i386, I've made every setting change I can think of (focusing on the font and DPI area) and have not been able to get it to crash.

[Fabien Tassin (fta)]

nothing special as far as i can remember, I'm afraid.
I'll try to gather more info tomorrow.

[Sebastien Bacher (seb128)]

could you run xdpyinfo and copy the log to a comment?

[Fabien Tassin (fta)]

I guess the relevant part is:

screen #0:
  dimensions: 1280x1024 pixels (0x0 millimeters)
  resolution: -2147483648x-2147483648 dots per inch
  depths (7): 24, 1, 4, 8, 15, 16, 32
  root window id: 0x76

which gives a dpi of -2^31

this is with fglrx on an embedded ATI Radeon Xpress 200G

[Sebastien Bacher (seb128)]

I've sent the bug upstream on http://bugzilla.gnome.org/show_bug.cgi?id=469580, the issue is partially due to the closed source binary drivers from ATI though

[Sebastien Bacher (seb128)]

The bug is fixed upstream now

[Fabien Tassin (fta)]

Thanks Sebastien. Do you plan to backport the patch or just wait for the next upstream release ?

[Sebastien Bacher (seb128)]

the next upstream version is next week there is no need to patch it now

[Sebastien Bacher (seb128)]

gnome-control-center (1:2.19.91-0ubuntu1) gutsy; urgency=low

  * New upstream version:
    about-me:
    - Honor mail address attributes when setting up Home and Work addresses
    appearance:
    - Don't leak the cursor font
    - Fix double-free and make the builtins non-static to save relocations
    - Properly check all installed themes if necessary
    - Free the metacity theme after use
    - Correct the item width and enable line wrapping for long theme names
    - If no background image set, select "no wallpaper"
    - Simply set the upper bound of the DPI spin button to the maximum we
      consider acceptable (LP: #134142)
    - Don't mark gtk-delete stock id for translation
    - Always generate thumbnails asynchronously
    default applications:
    - Add browser and mail entries Iceape
    - Use the new -new-tab and -new-window arguments instead of -remote for
      Firefox tab and window commands
    keyboard:
    - Disable "delete" button when no layout is selected
    - Make "Add label" string translatable
    settings daemon:
    - Use a list instead of a hash table to store the settings modules
    - Raise the volume when unmuting
    - Show X keyboard settings warning dialog delayed, so that it runs properly
      centered and with decorations
    - Initialize XKB config early so that callback would not crash (LP: #133576)
    general:
    - Hide the password in displayed URIs when transfering files
    updated translations
  * debian/patches/18_add_onboard_to_preferred_apps.patch:
    - patch from Chris Jones, "onboard still called sok in preferred apps list"
      (LP: #135381)
  * debian/patches/71_at_properties_gksudo_gdmsetup.patch:
    - patch from Chris Jones slightly modified to run gdmsetup with gksu
      (LP: #134958)
  * debian/patches/95_desktop-effects-integration.patch:
    - updated, limit glade changes to the new tab (LP: #129698)
  * debian/patches/99_autoreconf.patch:
    - updated
  * debian/patches/100_at_properties_readd_gksudo_disable_grab_toggle.patch:
    - patch from Chris Jones,
      "no gksu/disable-grab option per gui in gnome-at-properties" (LP: #133674)
  * debian/patches/101_gnome_at_properties_active_preferred_apps_without_at.patch:
    - patch from Chris Jones, to not "prevents access to preferred apps dialog
      when assistive technologies is not enabled" (LP: #135401)

 -- Sebastien Bacher <email address hidden> Wed, 29 Aug 2007 17:26:10 +0200