[library] fuel-library puppet-lint tests stop on first failure

[Andrew Woodward]

The puppet-lint tests from fuel-library/utils/jenkins/fuel_syntax_check.sh stops on the first failure instead of collecting all issues. This can lead to increased load on the CI infra as it requires more revisions to find all errors if not run locally.

[Aleksandra Fedorova (bookwar)]

I've removed '-e' from

/bin/bash -e $WORKSPACE/utils/jenkins/fuel_syntax_check.sh

command

[Aleksandra Fedorova (bookwar)]

Seems to be reverted by https://bugs.launchpad.net/fuel/+bug/1367506

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/139090

[Mike Scherbakov (mihgen)]

Moved to 6.1, as it is devops/CI issue and does not block 6.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/139090
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=47bf38d6803b659b79b4c3bd942fa569ee3ebfa2
Submitter: Jenkins
Branch: master

commit 47bf38d6803b659b79b4c3bd942fa569ee3ebfa2
Author: Aleksandr Didenko <email address hidden>
Date: Thu Dec 4 14:48:20 2014 +0200

    Refactor fuel syntax check script

    - Check syntax for changed modules only
    - Use 'rake lint' instead of 'puppet-lint' where possible
    - Use 'bundle' for rake lint tests
    - Fix current syntax errors that break 'rake lint' or disable
      'fail_on_warnings' option for lint

    Closes-bug: #1340336
    Change-Id: I66c5b4799dafc32e7903c16365a277109cfb6723

[Bogdan Dobrelya (bogdando)]

@Aleksandr, please update the status of your work in progress for 6.1 release and the status for 5.1?

[Aleksandr Didenko (adidenko)]

We won't use new syntax check for previous release since otherwise we'd have to fix all the linting errors for 6.0 and 5.1 which new test script will find. So it's released for 6.1 and "won't fix" for the others.