fuellib_review_syntax_check doesn't fail on errors

[Andrew Woodward]

In

https://fuel-jenkins.mirantis.com/job/fuellib_review_syntax_check/3244/consoleFull

The error

Error: Could not parse for environment production: Syntax error at '='; expected '|>' at /home/jenkins/workspace/fuellib_review_syntax_check@2/deployment/puppet/openstack/manifests/network.pp:99

was returned, however it doesn't cause the check script to fail

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120288

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/120427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120288
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=5fe00105bf198d80ee636dfe82a31df3a42dc48e
Submitter: Jenkins
Branch: master

commit 5fe00105bf198d80ee636dfe82a31df3a42dc48e
Author: Igor Shishkin <email address hidden>
Date: Wed Sep 10 04:28:23 2014 +0400

    Fix for non-failing on failed test

    Change-Id: I42d4c5d926b3edf33e01f463d4aa0f1ff85c0ee0
    Closes-Bug: #1367506

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120427
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=6fc7ac9041894aa76b2e18d385149166e34f7b23
Submitter: Jenkins
Branch: stable/5.1

commit 6fc7ac9041894aa76b2e18d385149166e34f7b23
Author: Igor Shishkin <email address hidden>
Date: Wed Sep 10 04:28:23 2014 +0400

    Fix for non-failing on failed test

    Change-Id: I42d4c5d926b3edf33e01f463d4aa0f1ff85c0ee0
    Closes-Bug: #1367506

[Andrew Woodward (xarses)]

Thanks for the quick turn, looking at the commit over again. I think it will now stop on the first failure which is better than before, but still less than ideal. If this is the case then we can lower this to med and work out a solution that will capture non-zero returns and allow the RC become -1 on exit.