PageHeader.Logo requires absolute path

[Michał Karnicki]

The scope framework should not require an absolute path to PageHeader.Logo, but also accept a relative one (relative to scope_directory(), I suppose).

[Michal Hruby (mhr3)]

Is this something the library should be doing automatically? Ie prepending the scope_dir to customization fields that hold relative paths?

[Michał Karnicki (karni)]

FTR
Icon =
in the same file accepts just the file name (or relative path, haven't tried, I just use the file name for the file that is in same directory as .ini and .so).

[Michi Henning (michihenning)]

I don't think it would be desirable to prepend anything to the configured path. For testing, it can be really useful to not have to muck around with absolute paths.

The Icon and Logo settings (among others) are never looked at by the scopes run time. They are just opaque values that are made available via the registry metadata. So, this really is something for the shell to decide.

[Michal Hruby (mhr3)]

@michi:

scoperegistry.cpp:

269: mi->set_art(relative_scope_path_to_abs_path(sc.art(), scope_dir).native());
276: mi->set_icon(relative_scope_path_to_abs_path(sc.icon(), scope_dir).native());

[Michi Henning (michihenning)]

Ah, yes. I missed that change when it was made. I guess it makes sense to do this here, because the shell has no idea where to look otherwise, and the run time knows about the icon and art config items.

But Pageheader.Logo is different, because the run time doesn't even know about the existence of that. This is purely an appearance attribute, as far as I know.

So, as far as I can see, the shell would have to convert this to an absolute path by prepending scope_directory() itself.

[Michal Hruby (mhr3)]

Right, and since the registry is already making it simple for the clients for the Art and Icon, we can special case some appearance attributes as well (the ones that are known to possibly point to a file)

[Michi Henning (michihenning)]

Cool. Just confirming, because it's not entirely clear to me from looking at the tutorial: Pageheader.Logo is expected to be path (not a URL), yes? If so, easy: I can just prepend the installation directory if the path isn't absolute.

I'll also add the attributes that are currently in tutorial.docx to the list of known attributes in ScopeConfig.cpp.

[Michi Henning (michihenning)]

I just set this as invalid for scopes-api because, as discussed in the stand-up, the shell will be dealing with this for now.

I'm about to open a separate bug for post-RTM regarding a more general stragegy for how to deal with URIs in the run time.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scopes-api - 0.5.2+14.10.20140723-0ubuntu1

---------------
unity-scopes-api (0.5.2+14.10.20140723-0ubuntu1) utopic; urgency=low

  [ Pete Woods ]
  * Normalize relative paths (LP: #1340135)

  [ Marcus Tomlinson ]
  * Call locate() before every two-way request. Increased two-way
    invocation timeouts.

  [ Michi Henning ]
  * Normalize relative paths (LP: #1340135)
 -- Ubuntu daily release <email address hidden> Wed, 23 Jul 2014 22:06:06 +0000