Launch instance: volume device name should be optional

[Julie Pichon]

From comment 9 on Nova bug 1337821, the device name should be optional and can cause issues if we force the user to select one and they enter an incorrect value. We should make the field optional (and make sure we still create the instance correctly in these cases.)

[Miguel Grinberg (miguelgrinberg)]

My plan is to hide the device name field when can_set_mount_point is False. If there are any problems with this approach please let me know.

[Miguel Grinberg (miguelgrinberg)]

Turns out bug 1273298 implements this fix in the same way I was planning to.

[Gary W. Smith (gary-w-smith)]

In addition to hiding the field, the validation logic must be changed to permit the device name to be unspecified.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114711

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114711
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7915b5bf833713da7bac99c6d9dedf8a9cac6c5b
Submitter: Jenkins
Branch: master

commit 7915b5bf833713da7bac99c6d9dedf8a9cac6c5b
Author: Miguel Grinberg <email address hidden>
Date: Sat Aug 16 00:38:58 2014 +0000

    allow empty device name when launching an instance

    From comment 9 on Nova bug 1337821, the device name should be optional
    and can cause issues if we force the user to select one and they enter
    an incorrect value. We should make the field optional (and make sure
    we still create the instance correctly in these cases.)

    Change-Id: I7745b67bc52bbfbb98aa223b6e14ae2f96d81339
    Closes-Bug: 1339760