OPENSTACK_HYPERVISOR_FEATURES['can_set_mount_point'] not taken in account when launching instances and creating a volume

Bug #1273298 reported by Yves-Gwenael Bourhis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Yves-Gwenael Bourhis

Bug Description

if in openstack_dashboard/test/settings.py we set :

OPENSTACK_HYPERVISOR_FEATURES = {
    'can_set_mount_point': False,
}

This hides the 'device' field of the AttachForm, but it should also hide the 'device_name' field of the 'SetInstanceDetailsAction' workflow action's form too.

Changed in horizon:
assignee: nobody → Yves-Gwenael Bourhis (yves-gwenael-bourhis)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69423

Changed in horizon:
status: New → In Progress
Revision history for this message
Jordan Pittier (jordan-pittier) wrote :

If and only if we select the option boot from image (create volume).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/69423
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=042899b649a553a91c6441c7b99f472622077d05
Submitter: Jenkins
Branch: master

commit 042899b649a553a91c6441c7b99f472622077d05
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Mon Jan 27 18:44:40 2014 +0100

    Hiding device name field when unhandled

    When OPENSTACK_HYPERVISOR_FEATURES['can_set_mount_point'] is set to false
    we hide the device_name field in the launch_instance form

    Change-Id: Id5eacbfc7fb230320e0d0bc8bcc839e285844f86
    Closes-Bug: 1273298

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.