Devices tab needs to use suru icon theme for button
Bug #1338936 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| qtcreator-plugin-ubuntu |
Fix Released
|
Wishlist
|
Benjamin Zeller | ||
| qtcreator-plugin-ubuntu (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
In the devices there are buttons to add an emulator or refresh the page however they are using old gnome icons. They should be using the suru icon theme considering we are using the Ubuntu SDK for other parts of the UI. See the attached screenshot for more details.
The packages required should be added as a dependency to the debian/control file, suru-icon-theme | ubuntu-mobile-icons so that compatibility can be maintained from trusty onwards.
Related branches
lp:~zeller-benjamin/qtcreator-plugin-ubuntu/kitcreate
- PS Jenkins bot: Approve (continuous-integration)
- Zoltan Balogh: Pending requested
-
Diff: 911 lines (+640/-63)13 files modifiedshare/qtcreator/ubuntu/devicespage/DeviceEmulatorTab.qml (+8/-4)
share/qtcreator/ubuntu/devicespage/DeviceKitManager.qml (+62/-0)
share/qtcreator/ubuntu/devicespage/DevicePage.qml (+29/-6)
share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml (+1/-39)
src/ubuntu/images/list-add.svg (+158/-0)
src/ubuntu/images/list-remove.svg (+152/-0)
src/ubuntu/images/reload.svg (+180/-0)
src/ubuntu/resources.qrc (+3/-0)
src/ubuntu/ubuntupackagingwidget.cpp (+6/-1)
src/ubuntu/ubuntuplugin.cpp (+6/-6)
src/ubuntu/ubunturemoterunconfiguration.cpp (+22/-3)
src/ubuntu/ubunturemoterunconfiguration.h (+2/-0)
src/ubuntu/ubunturemoteruncontrol.cpp (+11/-4)
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | #1 |
| Changed in qtcreator-plugin-ubuntu: | |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
| assignee: | nobody → zbenjamin (zeller-benjamin) |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in qtcreator-plugin-ubuntu (Ubuntu): | |
| status: | New → Fix Released |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package qtcreator-
---------------
qtcreator-
[ Zygmunt Krynicki ]
* This branch fixes two problems: 3b5a62a Fix parameter check in
'device_search' script 831db0a Don't ignore devices with upper-case
serial number
[ Benjamin Zeller ]
* Fix bug LP:1338936 "Use Suru Icon theme for buttons". Fix Bug
lp:1355086 "welcome wizard "do not show again" does not work if you
click cancel". Disable runconfiguration if the app is running to
prevent execution of the same configuration multiple times. Make it
possible to create Kits even if the Device is not attached. Do not
crash if there is no deploy configuration. Do not change the project
name if it contains a cmake var (LP: #1338936, #1355086)
-- Ubuntu daily release <email address hidden> Tue, 12 Aug 2014 08:12:11 +0000