cannot add users to a group

[Eric Peterson]

Steps to reproduce:
1) Create a group
2) Modify the group members
3) click the add button

(the add button fails to do anything)

The problem is somewhere around the _modal_form_add_members.html file.... in this code:

    /* as you navigate around the more pages, they stack on top of each other
        make sure this stack gets cleaned up so there is only on*/
    hidden_modals = $("#modal_wrapper .modal.hide:not(:last-child)");
    hidden_modals.detach();

If you comment out that detach method call, it now works.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104330

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104330
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e51a93b40be23836c7c5d78b51ee00bf70ab4ce4
Submitter: Jenkins
Branch: master

commit e51a93b40be23836c7c5d78b51ee00bf70ab4ce4
Author: Eric Peterson <email address hidden>
Date: Wed Jul 2 14:13:41 2014 -0600

    cannot add users to groups

    Correcting a javascript issue where the modal popup dialog
    for adding users to groups was being disposed / detached right away.

    The code removed does not seem to be needed or used anywhere.

    Change-Id: I299afef6da1c9bc7ab8668f44d08a67219777761
    Closes-Bug: 1336560

[Julie Pichon (jpichon)]

Should this be backported to Icehouse, does the problem occur there as well?

[Eric Peterson (ericpeterson-l)]

I believe this just came to be with a recent update of javascript
libraries. It has only occurred within that last 6 weeks or so on master.
 (that is all the more granularity I can vouch for)

Thanks,
Eric

On Thu, Jul 3, 2014 at 6:13 AM, Julie Pichon <email address hidden>
wrote:

> Should this be backported to Icehouse, does the problem occur there as
> well?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1336560
>
> Title:
> cannot add users to a group
>
> Status in OpenStack Dashboard (Horizon):
> Fix Committed
>
> Bug description:
> Steps to reproduce:
> 1) Create a group
> 2) Modify the group members
> 3) click the add button
>
> (the add button fails to do anything)
>
> The problem is somewhere around the _modal_form_add_members.html
> file.... in this code:
>
> /* as you navigate around the more pages, they stack on top of each
> other
> make sure this stack gets cleaned up so there is only on*/
> hidden_modals = $("#modal_wrapper .modal.hide:not(:last-child)");
> hidden_modals.detach();
>
>
> If you comment out that detach method call, it now works.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1336560/+subscriptions
>

[Eric Peterson (ericpeterson-l)]

I think this just came to be with some javascript library changes, made within the last 6 weeks or so. I *think* we are ok.