Read notifications are not deleted

[Kristina Hoeppner]

The "help" icon on the Inbox says: Read notifications will automatically expire and be removed from your list after 60 days.

However, this is not happening for me on mahara.org and another site.

[Kristina Hoeppner (kris-hoeppner)]

If it indeed doesn't work in general, the question is: Shall it work that way or shall it always be up to the user to delete messages? The 60 days are not obvious and you only know about them when you click the help icon.

[Tobias Zeuch (tobias-zeuch-8)]

When I look at a fresh installation, there is a cron job registered for cron_clean_internal_activity_notifications, that calls PluginNotificationInternal::clean_notifications, but the delay is set to 182 days and not 60, and the only notification types, that are actually deleted, are viewaccess, watchlist and institutionmessage.
I'm not sure about deleting whatever notification after a fixed time, when a user isn't able to store away messages he does not want deleted. Though viewaccess and watchlistnotification probably won't hurt.

[Kristina Hoeppner (kris-hoeppner)]

During today's dev meeting, the 34th, it was mentioned that it might be a good idea to make that delay configurable.

[Kristina Hoeppner (kris-hoeppner)]

I am changing the lang strings talking about notification expiry to the following for Mahara 1.10:

----------
<p><strong>Note:</strong> The following notification types expire automatically when you choose an email notification option and are deleted from your inbox after 6 months:</p>
<ul>
<li>Page access notifications</li>
<li>Watchlist notifications</li>
<li>Institution messages</li>
----------

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8146

[Niranjan (niranjan528)]

URL: https://bugs.launchpad.net/mahara/+bug/1334576

Bug description: Allowing admin setting for internal notification expiry.

Environment to be tested: Master
Browser to be tested: Any browser

Precondition:
1. A user with 'Site admin' access should exist.
2. Notifications in the ‘Site admin’ account are not set to ‘None’.
3. ‘Site admin’ should have existing system generated emails in the inbox with the following notification types,
-Page access notifications.
-Watch list notifications.
-Institution messages.
4. Make the changes in the database with the following command, so that the notifications are older than 2 days but not as old as
182 days.

 “update notification_internal_activity set ctime = '2017-11-02 12:13:14';”

Steps to reproduce:

1. Log in as a site admin user.
2. Navigate to Administration menu > Configure site > Site options
3. Click the ‘Notification settings’ panel.

Expected result: A new field ‘Internal notification expiry’ should be present and the default days should be displayed as ‘182’.

4. Click the ‘Help’ icon.

Expected result: The following text should be displayed

The following notification types will be deleted from your inbox after the specified days have elapsed:
-Page access notifications
-Watchlist notifications
-Institution messages

5. Change the ‘Internal notification expiry’ to ‘2’ days.
6. Click the ‘Update site options’ button.
7. Run the cron manually by adding /lib/cron.php to the end of the www root of your site.
8. Type the URL of your Mahara site in the browser's address bar as you'll be on a blank page only once the cron finished running.

Note: Refreshing the page wouldn't help as the URL would still be the cron URL and thus you wouldn't actually get to a better page.

9. Navigate to User menu > Inbox.

Expected result: All the system generated emails which are older than 2 days should not be displayed.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8146
Committed: https://git.mahara.org/mahara/mahara/commit/2a22b0ef8f051694241cd1bc38a00ea463329be1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2a22b0ef8f051694241cd1bc38a00ea463329be1
Author: Robert Lyon <email address hidden>
Date: Mon Oct 16 12:02:23 2017 +1300

Bug 1334576: Allowing admin setting for internal notification expiry

behatnotneeded

Change-Id: I7d6b761ebf28275a2608a6b1157c96da0922d5f0
Signed-off-by: Robert Lyon <email address hidden>